Skip to content

fix: Fix NIXL 0.3.1 build #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jthomson04 merged 2 commits into from
Jun 17, 2025
Merged

fix: Fix NIXL 0.3.1 build #1561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49ea79e
Fix 0.3.1 build
jthomson04 Jun 17, 2025
c8e883b
Update lockfile
jthomson04 Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions lib/bindings/python/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/llm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ regex = "1"
rayon = "1"

# block_manager
nixl-sys = { version = "0.3.0-rc.2", optional = true }
nixl-sys = {git="https://github.com/ai-dynamo/nixl", rev = "a7c654d46a14cd5ce635cc8c02433d71df93dedf", optional = true }
cudarc = { version = "0.16.2", features = ["cuda-12020"], optional = true }
ndarray = { version = "0.16", optional = true }
nix = { version = "0.26", optional = true }
Expand Down
4 changes: 2 additions & 2 deletions lib/llm/src/block_manager/block/transfer/nixl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ where
.storage_type()
.nixl_mem_type();

let mut src_dl = XferDescList::new(src_mem_type)?;
let mut dst_dl = XferDescList::new(dst_mem_type)?;
let mut src_dl = XferDescList::new(src_mem_type, true)?;
let mut dst_dl = XferDescList::new(dst_mem_type, true)?;

for (src, dst) in src.iter().zip(dst.iter_mut()) {
append_xfer_request(src, dst, &mut src_dl, &mut dst_dl)?;
Expand Down
Loading