chore: remove vLLM v0 multimodal example #2099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuanLuo
requested review from
hhzhang16,
indrajit96,
krishung5 and
whoisj
as code owners
Contributor
WalkthroughThis change removes the entire multimodal example codebase, including all Python modules, utility scripts, configuration files, Kubernetes deployment manifests, and documentation related to distributed multimodal model serving (images, video, and text) using vLLM and the Dynamo framework. All associated classes, endpoints, protocols, connectors, and deployment resources are deleted. Changes
Sequence Diagram(s)Omitted due to the removal-only nature of the change. Estimated code review effort🎯 5 (Critical) | ⏱️ ~70+ minutes This is a critical, high-effort review due to the complete removal of a large, complex example codebase with numerous interdependent components, protocols, utilities, and deployment resources. Possibly related PRs
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (40)
💤 Files with no reviewable changes (40)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Contributor
Author
|
@atchernych I made this PR for the removal |
Contributor
|
:) Awesome @GuanLuo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
End-users will no longer have access to multimodal example pipelines, utilities, deployment configs, or related documentation.