Skip to content

Conversation

@krishung5
Copy link
Contributor

@krishung5 krishung5 commented Jul 31, 2025

Overview:

Multimodal example will be added back post-0.4.0 release.

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

  • Documentation
    • Removed the comprehensive README guide for deploying and testing multimodal models with the Dynamo framework, including setup instructions, deployment scenarios, and example workflows.

@krishung5 krishung5 requested a review from GuanLuo July 31, 2025 04:35
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 31, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 31, 2025

Walkthrough

The change deletes the comprehensive README documentation for multimodal model deployment examples in the Dynamo framework. No source code or API declarations are affected; only the example documentation file is removed.

Changes

Cohort / File(s) Change Summary
Documentation Removal
examples/basics/multimodal/README.md
Deleted the detailed README file that provided instructions, examples, and architecture diagrams for multimodal model deployment using Dynamo.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

A README once lived in the multimodal den,
With diagrams and guides for every model and pen.
Now it hops away, leaving folders more light,
The docs may be gone, but the code’s still in sight!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 97390ac and d763c56.

📒 Files selected for processing (1)
  • examples/basics/multimodal/README.md (0 hunks)
💤 Files with no reviewable changes (1)
  • examples/basics/multimodal/README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build and Test - vllm

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@whoisj
Copy link
Collaborator

whoisj commented Jul 31, 2025

closes GitHub issue: #xxx

Is this something that has been asked for? If so, is there a work item or issue associated with it?

@nealvaidya
Copy link
Contributor

nealvaidya commented Jul 31, 2025

Is this something that has been asked for? If so, is there a work item or issue associated with it?

@whoisj The actual example was removed in #2099 but somehow the readme got left behind. I think this is just finishing the job -- a new multimodal example is being worked on here: #2040

@krishung5 krishung5 merged commit f14f59c into main Jul 31, 2025
9 checks passed
@krishung5 krishung5 deleted the krish/rm-multimodal-example branch July 31, 2025 23:07
krishung5 added a commit that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants