fix: 0.4.1 disable kvbm tests (CP #2611) #2635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-tokarev-nv
requested review from
a team,
alec-flowers,
ishandhanani,
nnshah1,
piotrm-nvidia,
ptarasiewiczNV,
richardhuo-nv,
rmccorm4,
ryanolson and
tanmayv25
as code owners
dmitry-tokarev-nv
requested review from
a team,
GuanLuo,
PeaBrane,
biswapanda,
grahamking,
hhzhang16,
jthomson04,
kkranen,
paulhendricks,
tedzhouhk and
tmonty12
as code owners
dmitry-tokarev-nv
changed the title
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughBulk updates switch default model references to Qwen/Qwen3-0.6B, bump TensorRT-LLM pins to 1.0.0rc6 with container/version alignments, adjust UCX refs to v1.19.0, remove the local async-openai-macros crate in favor of a published dependency, and add SGLang runtime behavior tweaks (frontend tokenization default, decode error guard). Tests and docs updated accordingly. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Client
participant Frontend (Dynamo)
participant Worker (SGLang)
rect rgb(245,248,255)
note over Frontend (Dynamo): Tokenization enforced (skip_tokenizer_init=True)
Client->>Frontend (Dynamo): /v1/chat/completions
Frontend (Dynamo)->>Frontend (Dynamo): Tokenize input
Frontend (Dynamo)->>Worker (SGLang): Prefill/Decode request (no tokenizer init)
end
alt Streaming tokens
Worker (SGLang)-->>Frontend (Dynamo): res with output_ids
Frontend (Dynamo)->>Client: stream tokens
else Missing output_ids
Worker (SGLang)-->>Frontend (Dynamo): res without output_ids
Frontend (Dynamo)->>Frontend (Dynamo): raise ValueError with keys hint
Frontend (Dynamo)-->>Client: error response
end
Frontend (Dynamo)->>Frontend (Dynamo): Detokenize (if needed)
Frontend (Dynamo)-->>Client: final response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (45)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Cherry-pick for #2611
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores
Tests