Skip to content

Conversation

@grahamking
Copy link
Contributor

@grahamking grahamking commented Aug 20, 2025

Use upstream. It's very small so if upstream stops working for us we should fold it into async-openai, to avoid publishing another crate.

Summary by CodeRabbit

  • Chores
    • Migrated macro functionality to a published dependency, simplifying builds and dependency management.
    • Removed the in-repo macros crate from the workspace to reduce repository footprint.
    • Updated dependencies to use a versioned release (0.1.0) for improved stability.
    • No changes to the public API or behavior; existing integrations continue to work without modification.
    • End users should experience smoother installation and consistent builds with no required actions.

Use upstream. It's very small so if upstream stops working for us we
should fold it into async-openai, to avoid publishing another crate.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 20, 2025

Walkthrough

Removed the in-repo procedural macro crate from the workspace and codebase, and switched the async-openai crate to depend on an external published version (0.1.0) of async-openai-macros. Updated the root workspace members accordingly. No public API changes within this repository are introduced.

Changes

Cohort / File(s) Summary
Workspace membership update
Cargo.toml
Removed lib/async-openai-macros from workspace members.
Remove in-repo proc-macro crate
lib/async-openai-macros/Cargo.toml, lib/async-openai-macros/src/lib.rs
Deleted the crate manifest and source, removing the byot and byot_passthrough procedural macros implementation from the repo.
Dependency source switch
lib/async-openai/Cargo.toml
Changed async-openai-macros dependency from a local path to a versioned crate: async-openai-macros = "0.1.0".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibbled the weeds from our garden of crates,
Snipped a macro burrow, lightening our weights.
Now I hop to the registry, swift and spry,
Version in paw, dependencies fly.
Fewer tunnels to map, more clover to chew—
Ship it, thump-thump! The path is new. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
lib/async-openai/Cargo.toml (1)

36-36: Consider pinning exactly to 0.1.0 for reproducibility and supply-chain safety

The bare string "0.1.0" is a caret requirement (^0.1.0) and will float to any 0.1.x. Given this is a proc-macro (compile-time impact) and pre-1.0 semantics, you may want stricter pinning to avoid accidental breaks and ensure deterministic builds across CI and consumers.

Apply this diff if you prefer exact pinning:

-async-openai-macros = "0.1.0"
+async-openai-macros = "=0.1.0"

Alternatively:

  • Keep caret in-tree but pin via workspace Cargo.lock (sufficient if all builds go through the workspace).
  • Add a [patch.crates-io] override if you need a hotfix fork without reintroducing a local crate.
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f73d35d and ef53d2f.

⛔ Files ignored due to path filters (2)
  • Cargo.lock is excluded by !**/*.lock
  • lib/bindings/python/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • Cargo.toml (0 hunks)
  • lib/async-openai-macros/Cargo.toml (0 hunks)
  • lib/async-openai-macros/src/lib.rs (0 hunks)
  • lib/async-openai/Cargo.toml (1 hunks)
💤 Files with no reviewable changes (3)
  • Cargo.toml
  • lib/async-openai-macros/src/lib.rs
  • lib/async-openai-macros/Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Mirror Repository to GitLab
  • GitHub Check: Build and Test - dynamo
  • GitHub Check: pre-merge-rust (lib/runtime/examples)
  • GitHub Check: pre-merge-rust (lib/bindings/python)
  • GitHub Check: pre-merge-rust (.)
🔇 Additional comments (2)
lib/async-openai/Cargo.toml (2)

36-36: Switch to upstream macros crate looks good and matches PR intent

Replacing the former path dependency with the published crate aligns with the PR objective and keeps the workspace lean. No public API impact within this repo.


36-36: async-openai-macros 0.1.0 confirmed on crates.io – no path deps remain
Verified that:

  • async-openai-macros version 0.1.0 exists on crates.io, is not yanked, and is MIT-licensed
  • No TOML path dependencies referencing async-openai-macros remain in the repo

@grahamking grahamking enabled auto-merge (squash) August 20, 2025 17:48
@grahamking grahamking merged commit 4995843 into main Aug 20, 2025
15 of 16 checks passed
@grahamking grahamking deleted the gk-aom branch August 20, 2025 18:33
grahamking added a commit that referenced this pull request Aug 21, 2025
hhzhang16 pushed a commit that referenced this pull request Aug 27, 2025
nv-anants pushed a commit that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants