-
Notifications
You must be signed in to change notification settings - Fork 764
chore: Remove async-openai-macros #2554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use upstream. It's very small so if upstream stops working for us we should fold it into async-openai, to avoid publishing another crate.
WalkthroughRemoved the in-repo procedural macro crate from the workspace and codebase, and switched the async-openai crate to depend on an external published version (0.1.0) of async-openai-macros. Updated the root workspace members accordingly. No public API changes within this repository are introduced. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
lib/async-openai/Cargo.toml (1)
36-36: Consider pinning exactly to 0.1.0 for reproducibility and supply-chain safetyThe bare string "0.1.0" is a caret requirement (^0.1.0) and will float to any 0.1.x. Given this is a proc-macro (compile-time impact) and pre-1.0 semantics, you may want stricter pinning to avoid accidental breaks and ensure deterministic builds across CI and consumers.
Apply this diff if you prefer exact pinning:
-async-openai-macros = "0.1.0" +async-openai-macros = "=0.1.0"Alternatively:
- Keep caret in-tree but pin via workspace Cargo.lock (sufficient if all builds go through the workspace).
- Add a
[patch.crates-io]override if you need a hotfix fork without reintroducing a local crate.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
Cargo.lockis excluded by!**/*.locklib/bindings/python/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (4)
Cargo.toml(0 hunks)lib/async-openai-macros/Cargo.toml(0 hunks)lib/async-openai-macros/src/lib.rs(0 hunks)lib/async-openai/Cargo.toml(1 hunks)
💤 Files with no reviewable changes (3)
- Cargo.toml
- lib/async-openai-macros/src/lib.rs
- lib/async-openai-macros/Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Mirror Repository to GitLab
- GitHub Check: Build and Test - dynamo
- GitHub Check: pre-merge-rust (lib/runtime/examples)
- GitHub Check: pre-merge-rust (lib/bindings/python)
- GitHub Check: pre-merge-rust (.)
🔇 Additional comments (2)
lib/async-openai/Cargo.toml (2)
36-36: Switch to upstream macros crate looks good and matches PR intentReplacing the former path dependency with the published crate aligns with the PR objective and keeps the workspace lean. No public API impact within this repo.
36-36: async-openai-macros 0.1.0 confirmed on crates.io – no path deps remain
Verified that:
async-openai-macrosversion 0.1.0 exists on crates.io, is not yanked, and is MIT-licensed- No TOML path dependencies referencing
async-openai-macrosremain in the repo
Signed-off-by: Hannah Zhang <[email protected]>
Use upstream. It's very small so if upstream stops working for us we should fold it into async-openai, to avoid publishing another crate.
Summary by CodeRabbit