Skip to content

Conversation

@krishung5
Copy link
Contributor

@krishung5 krishung5 commented Aug 22, 2025

Overview:

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

  • Documentation
    • Clarified current multimodal model support: only LLaVA 1.5 7B is supported; Qwen2.5-VL and Phi-3V are planned for future releases.
    • Removed outdated, commented example commands for unsupported models to avoid confusion.
    • Refreshed docs to set accurate expectations and streamline setup.
    • No changes to features, APIs, or behavior; documentation-only update. No action required.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 22, 2025

Walkthrough

Documentation update to examples/multimodal/README.md clarifying supported model (LLaVA 1.5 7B), removing commented serve commands for Qwen2.5-VL and Phi3V, and noting future support plans. No code or behavior changes.

Changes

Cohort / File(s) Summary of Changes
Docs – Multimodal README
examples/multimodal/README.md
Added note that only LLaVA 1.5 7B is currently supported; removed commented commands for Qwen2.5-VL-7B-Instruct and Phi-3.5-vision-instruct; no functional changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Hop hop! I tweak the docs with care,
A single model listed, crystal-clear and fair.
Old commented whispers, now tidied away,
Future friends promised—another day.
In README fields I plant the seed,
For multimodal sprouts to grow at speed. 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
examples/multimodal/README.md (2)

62-63: Unify model naming (Phi variant) across the doc.

Use a single name for the Phi model to avoid ambiguity (Phi3V vs. PhiV vs. Phi-3.5-Vision). Recommend “Phi-3.5-Vision” to match the model id used later.

Apply these diffs:

-**Note:** This aggregated example is currently validated only with LLaVA 1.5 7B (model id: llava-hf/llava-1.5-7b-hf). Support for Qwen2.5-VL and Phi-3.5-Vision is planned; please do not substitute other models yet.
+**Note:** This aggregated example is currently validated only with LLaVA 1.5 7B (model id: llava-hf/llava-1.5-7b-hf). Support for Qwen2.5-VL and Phi-3.5-Vision is planned; please do not substitute other models yet.
-***Note***: disaggregation is currently only confirmed to work with LLaVA. Qwen VL and PhiV are not confirmed to be supported.
+***Note***: Disaggregation is currently only confirmed to work with LLaVA. Qwen2.5-VL and Phi-3.5-Vision are not yet confirmed to be supported.

Also applies to: 179-179


20-21: Clarify versions and polish product naming.

  • “vLLM v1” is vague; consider stating the minimum tested vLLM version or linking to your compatibility matrix.
  • Capitalize “Dynamo” for consistency with the project name.

Apply this diff for naming:

-We recommend using the latest stable release of dynamo to avoid breaking changes:
+We recommend using the latest stable release of Dynamo to avoid breaking changes:

If helpful, I can add a short “Requirements” subsection listing the tested vLLM version and GPU/driver stack; confirm the exact versions you want documented.

Also applies to: 24-24

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b92a805 and 3d049f3.

📒 Files selected for processing (1)
  • examples/multimodal/README.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build and Test - dynamo
🔇 Additional comments (1)
examples/multimodal/README.md (1)

64-68: All referenced multimodal launch scripts and components are present and runnable
All four examples/multimodal/launch/*.sh scripts (agg.sh, disagg.sh, agg_llama.sh, disagg_llama.sh) exist with valid #! shebangs and are marked executable. Both examples/multimodal/components/encode_worker.py and worker.py are also present. No updates needed to keep the README copy-paste runnable.

@krishung5 krishung5 changed the title doc: Update supported model in readme for multimodal docs: Update supported model in readme for multimodal Aug 22, 2025
@github-actions github-actions bot added the docs label Aug 22, 2025
@krishung5 krishung5 enabled auto-merge (squash) August 22, 2025 18:42
@krishung5 krishung5 merged commit 5045f13 into main Aug 22, 2025
8 of 9 checks passed
@krishung5 krishung5 deleted the krish/doc branch August 22, 2025 19:28
hhzhang16 pushed a commit that referenced this pull request Aug 27, 2025
jasonqinzhou pushed a commit that referenced this pull request Aug 30, 2025
KrishnanPrash pushed a commit that referenced this pull request Sep 2, 2025
nnshah1 pushed a commit that referenced this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants