-
Notifications
You must be signed in to change notification settings - Fork 751
docs: Update supported model in readme for multimodal #2651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDocumentation update to examples/multimodal/README.md clarifying supported model (LLaVA 1.5 7B), removing commented serve commands for Qwen2.5-VL and Phi3V, and noting future support plans. No code or behavior changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
examples/multimodal/README.md (2)
62-63: Unify model naming (Phi variant) across the doc.Use a single name for the Phi model to avoid ambiguity (Phi3V vs. PhiV vs. Phi-3.5-Vision). Recommend “Phi-3.5-Vision” to match the model id used later.
Apply these diffs:
-**Note:** This aggregated example is currently validated only with LLaVA 1.5 7B (model id: llava-hf/llava-1.5-7b-hf). Support for Qwen2.5-VL and Phi-3.5-Vision is planned; please do not substitute other models yet. +**Note:** This aggregated example is currently validated only with LLaVA 1.5 7B (model id: llava-hf/llava-1.5-7b-hf). Support for Qwen2.5-VL and Phi-3.5-Vision is planned; please do not substitute other models yet.-***Note***: disaggregation is currently only confirmed to work with LLaVA. Qwen VL and PhiV are not confirmed to be supported. +***Note***: Disaggregation is currently only confirmed to work with LLaVA. Qwen2.5-VL and Phi-3.5-Vision are not yet confirmed to be supported.Also applies to: 179-179
20-21: Clarify versions and polish product naming.
- “vLLM v1” is vague; consider stating the minimum tested vLLM version or linking to your compatibility matrix.
- Capitalize “Dynamo” for consistency with the project name.
Apply this diff for naming:
-We recommend using the latest stable release of dynamo to avoid breaking changes: +We recommend using the latest stable release of Dynamo to avoid breaking changes:If helpful, I can add a short “Requirements” subsection listing the tested vLLM version and GPU/driver stack; confirm the exact versions you want documented.
Also applies to: 24-24
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
examples/multimodal/README.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build and Test - dynamo
🔇 Additional comments (1)
examples/multimodal/README.md (1)
64-68: All referenced multimodal launch scripts and components are present and runnable
All fourexamples/multimodal/launch/*.shscripts (agg.sh, disagg.sh, agg_llama.sh, disagg_llama.sh) exist with valid#!shebangs and are marked executable. Bothexamples/multimodal/components/encode_worker.pyandworker.pyare also present. No updates needed to keep the README copy-paste runnable.
Signed-off-by: Hannah Zhang <[email protected]>
Signed-off-by: Jason Zhou <[email protected]>
Signed-off-by: Krishnan Prashanth <[email protected]>
Signed-off-by: nnshah1 <[email protected]>
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit