chore: vllm 0.10.1.1 #2691
Merged
chore: vllm 0.10.1.1 #2691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-tokarev-nv
requested review from
a team,
GuanLuo,
PeaBrane,
alec-flowers,
biswapanda,
grahamking,
hhzhang16,
hutm,
indrajit96,
ishandhanani,
jthomson04,
julienmancuso,
kkranen,
krishung5,
mohammedabdulwahhab,
nealvaidya,
nnshah1,
paulhendricks,
piotrm-nvidia,
ptarasiewiczNV,
richardhuo-nv,
rmccorm4,
ryanolson,
tanmayv25,
tedzhouhk,
tmonty12 and
whoisj
as code owners
Contributor
|
Caution Review failedFailed to post review comments. Configuration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (59)
💤 Files with no reviewable changes (7)
🧰 Additional context used🧠 Learnings (5)📚 Learning: 2025-07-28T17:00:07.968ZApplied to files:
📚 Learning: 2025-07-03T10:14:30.570ZApplied to files:
📚 Learning: 2025-07-01T15:33:53.262ZApplied to files:
📚 Learning: 2025-08-18T16:52:15.659ZApplied to files:
📚 Learning: 2025-08-18T16:52:15.659ZApplied to files:
🪛 Shellcheck (0.10.0)container/build.sh[warning] 62-62: TRTLLM_BASE_IMAGE_TAG appears unused. Verify use (or export if used externally). (SC2034) 🪛 YAMLlint (1.37.1)examples/multimodal/deploy/agg_llava.yaml[error] 68-68: no new line character at the end of file (new-line-at-end-of-file) 🪛 LanguageTooldocs/support_matrix.md[grammar] ~70-~70: There might be a mistake here. (QB_NEW_EN) [grammar] ~73-~73: There might be a mistake here. (QB_NEW_EN) [grammar] ~80-~80: There might be a mistake here. (QB_NEW_EN) [grammar] ~81-~81: There might be a mistake here. (QB_NEW_EN) components/backends/sglang/docs/sgl-hicache-example.md[grammar] ~26-~26: There might be a mistake here. (QB_NEW_EN) [grammar] ~26-~26: There might be a mistake here. (QB_NEW_EN) 🪛 markdownlint-cli2 (0.17.2)components/backends/trtllm/gpt-oss.md217-217: Fenced code blocks should have a language specified (MD040, fenced-code-language) 222-222: Fenced code blocks should have a language specified (MD040, fenced-code-language) components/backends/trtllm/llama4_plus_eagle.md33-33: Unordered list style (MD004, ul-style) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
WalkthroughThis PR updates defaults and docs to switch models to Qwen/Qwen3-0.6B, bumps several container/tooling versions (TensorRT-LLM rc6, PyTorch 25.06, UCX v1.19.0, vLLM 0.10.1.1), restructures Helm templates for component-type-aware commands/probes, adds SGLang CLI behavior (auto skip_tokenizer_init) and decode error handling, removes a local Rust proc-macro crate, and adjusts examples/tests. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User
participant Frontend as Dynamo Frontend
participant SGLang as SGLang Worker
Note over Frontend,SGLang: New default: skip_tokenizer_init=true when using frontend
User->>Frontend: Request (chat/completions)
Frontend->>Frontend: Tokenize/Detokenize (frontend)
Frontend->>SGLang: Generate stream (skip tokenizer init)
SGLang-->>Frontend: Stream chunks (may omit output_ids)
alt Missing output_ids
SGLang-->>Frontend: Error (ValueError with keys and guidance)
Frontend-->>User: Error response
else Normal stream
Frontend-->>User: Stream tokens
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60–90 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
krishung5
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
cherry-pick #2641
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Tests
Chores