fix: fix hello world #2727 #2731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biswapanda
requested review from
a team,
GuanLuo,
PeaBrane,
alec-flowers,
grahamking,
hhzhang16,
hutm,
indrajit96,
ishandhanani,
julienmancuso,
kkranen,
krishung5,
mohammedabdulwahhab,
nealvaidya,
nnshah1,
paulhendricks,
piotrm-nvidia,
ptarasiewiczNV,
richardhuo-nv,
rmccorm4,
ryanolson,
tanmayv25,
tedzhouhk,
tmonty12 and
whoisj
as code owners
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThe PR updates docs and configs broadly, switches default/example models to Qwen/Qwen3-0.6B, bumps multiple container/dependency versions, removes an internal Rust macro crate, adds shared-memory configuration to CRDs/operator, enhances Helm templates for frontend/worker roles, and introduces SGLang worker readiness gating and tokenizer-init behavior changes. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Client
participant Frontend as Frontend (dynamo.frontend)
participant Worker as SGLang Worker
participant Runtime as Runtime Registry
rect rgba(200,220,255,0.25)
note over Worker: Startup
Worker->>Worker: parse args
alt skip_tokenizer_init not set
Worker->>Worker: warn and set skip_tokenizer_init=true
end
par
Worker->>Runtime: register_llm_with_runtime_config()
Runtime-->>Worker: success (bool)
and
Worker->>Worker: start endpoints (generate via gate)
end
alt registration failed
Worker->>Worker: shutdown runtime, raise error
else registration succeeded
Worker->>Worker: set ready_event
end
end
rect rgba(200,255,200,0.25)
note over Client,Worker: Request flow after readiness
Client->>Frontend: /v1/chat/completions
Frontend->>Worker: dyn://sglang.generate (queued until ready)
Worker-->>Frontend: stream tokens
Frontend-->>Client: response
end
rect rgba(255,230,200,0.25)
note over Worker: Decode stream safety
Worker->>Worker: process stream
alt output_ids missing
Worker->>Worker: raise ValueError (descriptive)
end
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~70 minutes Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.2.2)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/product/migration-guide for migration instructions Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Cherry pick: #2727
liveness and readiness check for hello world should be exit 0
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores