Skip to content

chore(test): Copy pyproject.toml into containers to avoid 'unknown pytest marker' spam during pytest execution #4378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rmccorm4 wants to merge 9 commits into from
+15 −7
Closed

chore(test): Copy pyproject.toml into containers to avoid 'unknown pytest marker' spam during pytest execution #4378

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3965a98
chore(test): Copy pyproject.toml into containers to avoid huge spam o…
rmccorm4 Nov 15, 2025
4da8c9d
Ignore transformers/nvidia-modelopt warning: if the tests pass it is …
rmccorm4 Nov 15, 2025
845a2a1
Add ignore for TORCH_CUDA_ARCH_LIST warning, we don't currently set it
rmccorm4 Nov 15, 2025
67f1fbf
Try skipping mypy on sglang/trtllm
rmccorm4 Nov 15, 2025
e306490
Try skipping mypy only on unit tests
rmccorm4 Nov 16, 2025
73dfca4
Remove --mypy from addopts altogether
rmccorm4 Nov 16, 2025
1c432a9
Revert "Try skipping mypy only on unit tests"
rmccorm4 Nov 16, 2025
4776ab4
Revert "Try skipping mypy on sglang/trtllm"
rmccorm4 Nov 16, 2025
74744dd
Add -s -v for debug
rmccorm4 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Try skipping mypy only on unit tests" 
This reverts commit e306490.
  • Loading branch information
@rmccorm4
rmccorm4 committed Nov 16, 2025
commit 1c432a91a8fe6dfbfcc30f1a8a4420186fc084c1
12 changes: 2 additions & 10 deletions .github/actions/pytest/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,20 +54,12 @@ runs:
# Run pytest with detailed output and JUnit XML
set +e # Don't exit on test failures

# Disable mypy for unit tests to avoid CUDA cleanup segfaults (exit code 139)
# Unit tests import GPU framework modules which conflict with mypy's import system during cleanup
MYPY_FLAG=""
if [[ "${{ inputs.test_type }}" == *"unit"* ]]; then
MYPY_FLAG="-p no:mypy"
echo "Disabling mypy plugin for unit tests to avoid CUDA cleanup issues"
fi

docker run --runtime=nvidia --gpus all -w /workspace \
--cpus=${NUM_CPUS} \
--network host \
--name ${{ env.CONTAINER_ID }}_pytest \
${{ inputs.image_tag }} \
bash -c "mkdir -p /workspace/test-results && pytest -v --tb=short --basetemp=/tmp -o cache_dir=/tmp/.pytest_cache --junitxml=/workspace/test-results/${{ env.PYTEST_XML_FILE }} --durations=10 ${MYPY_FLAG} -m \"${{ inputs.pytest_marks }}\""
bash -c "mkdir -p /workspace/test-results && pytest -v --tb=short --basetemp=/tmp -o cache_dir=/tmp/.pytest_cache --junitxml=/workspace/test-results/${{ env.PYTEST_XML_FILE }} --durations=10 -m \"${{ inputs.pytest_marks }}\""

TEST_EXIT_CODE=$?
echo "TEST_EXIT_CODE=${TEST_EXIT_CODE}" >> $GITHUB_ENV
Expand Down Expand Up @@ -138,4 +130,4 @@ runs:
path: |
test-results/pytest_test_report_${{ inputs.framework }}_${{ env.STR_TEST_TYPE }}_${{ inputs.platform_arch }}.xml
test-results/test_metadata_${{ inputs.framework }}_${{ env.STR_TEST_TYPE }}_${{ inputs.platform_arch }}.json
retention-days: 7
retention-days: 7