Skip to content

Replace hashish with lodash#89

Merged
shime merged 2 commits intoairbrake:masterfrom
ebramanti:replace-hashish-with-lodash
Mar 3, 2016
Merged

Replace hashish with lodash#89
shime merged 2 commits intoairbrake:masterfrom
ebramanti:replace-hashish-with-lodash

Conversation

@ebramanti
Copy link
Copy Markdown
Contributor

node-hashish is a pretty out-of-date package (Last updated May 2013), so I replaced the dependency with lodash for the instances where node-airbrake uses it. I also used lodash to now inherit the prototype of EventEmitter.

Last commit on Hashish was May 2013, Lodash is a better-maintained
package with the same functionality.
Also moves module.exports after prototype declarations for more
clarity, even though Airbrake will be hoisted.
shime pushed a commit that referenced this pull request Mar 3, 2016
@shime shime merged commit 28f3212 into airbrake:master Mar 3, 2016
@shime
Copy link
Copy Markdown
Contributor

shime commented Mar 3, 2016

Thanks!

@ebramanti ebramanti deleted the replace-hashish-with-lodash branch April 24, 2016 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants