Skip to content

Replace hashish with lodash #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shime merged 2 commits into from
Mar 3, 2016
Merged

Replace hashish with lodash #89

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07f4961
Replace hashish with lodash
ebramanti Mar 2, 2016
27409c0
Use lodash to inherit EventEmitter
ebramanti Mar 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use lodash to inherit EventEmitter 
Also moves module.exports after prototype declarations for more
clarity, even though Airbrake will be hoisted.
  • Loading branch information
@ebramanti
ebramanti committed Mar 2, 2016
commit 27409c0d43ad732cfaa63e6f041de903decfd7fb
8 changes: 4 additions & 4 deletions lib/airbrake.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ var HTTP_STATUS_CODES = require('http').STATUS_CODES;
var fs = require('fs');
var os = require('os');
var EventEmitter = require('events').EventEmitter;
var util = require('util');
var request = require('request');
var xmlbuilder = require('xmlbuilder');
var stackTrace = require('stack-trace');
Expand All @@ -12,9 +11,6 @@ var querystring = require('querystring');
var stringify = require('json-stringify-safe');
var url = require('url');

module.exports = Airbrake;
util.inherits(Airbrake, EventEmitter);

function Airbrake() {
this.key = null;
this.projectId = null;
Expand Down Expand Up @@ -51,6 +47,8 @@ function Airbrake() {
];
}

_.assign(Airbrake.prototype, EventEmitter.prototype);

Airbrake.PACKAGE = (function() {
var json = fs.readFileSync(__dirname + '/../package.json', 'utf8');
return JSON.parse(json);
Expand Down Expand Up @@ -367,3 +365,5 @@ Airbrake.prototype.deploymentPostData = function(params) {
'repository': params.repo
});
};

module.exports = Airbrake;