chore: migrate from pnpm to npm for package management #104
Conversation
- Remove pnpm-specific files (pnpm-lock.yaml, pnpm-workspace.yaml, .npmrc) - Remove packageManager field from root package.json - Remove pnpm-specific configuration from package.json files - Update prepublishOnly script to use npm instead of pnpm - Update README.md to replace pnpm commands with npm equivalents - Generate package-lock.json and install dependencies with npm - Verify MCP server starts successfully (107 handlers registered) Reason: Simplify package management by using npm only, which is standard for MCP server distribution and avoids confusion between development (pnpm) and production (npm/npx) environments. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Warning Rate limit exceeded@akiojin has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 7 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Walkthroughプロジェクトのパッケージマネージャーをpnpmからnpmへ移行する変更。リポジトリ内のpnpm固有設定・コマンドを削除し、README、CIワークフロー、パッケージ定義などをnpm/npx相当へ置換している。 Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer
participant Repo as Repository
participant CI as GitHub Actions
Note over Repo: 変更: pnpm -> npm
Dev->>Repo: push changes (README, package.json, workflows)
CI->>Repo: checkout
CI->>CI: setup-node (cache: npm)
CI->>CI: run `npm ci`
CI->>CI: run tests via `npm run ...` / `npx ...`
CI-->>Dev: build & publish steps using npm/npx
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,6313 +0,0 @@ | |||
| lockfileVersion: '9.0' | |||
There was a problem hiding this comment.
Removing pnpm-lock.yaml means the CI workflows that still run pnpm install --frozen-lockfile (e.g. test.yml/release.yml/publish.yml) will now fail immediately, because pnpm requires an existing lockfile when --frozen-lockfile is passed. Any pipeline run that uses those jobs will error out before tests even execute. Keep the lockfile or update the workflows to npm so CI remains runnable.
Useful? React with 👍 / 👎.
- Remove pnpm setup steps from all workflows - Replace pnpm install with npm ci - Replace pnpm exec with npx - Replace pnpm --filter with npm --workspace - Update Node.js cache from pnpm to npm - Remove pnpm-lock.yaml cache dependency paths Affected workflows: - lint.yml: markdownlint, eslint, prettier, commitlint - test.yml: test:ci, test:ci:coverage, npm pack - release.yml: pre-release tests, semantic-release - publish.yml: test:ci, npm publish - create-release.yml: semantic-release dry-run 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
All CI checks passed! ✅ Status:
The PR is ready to merge once the base branch is up to date. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Complete the pnpm to npm migration by removing all pnpm references from the Japanese README. This fixes the incomplete migration in PR #104. Changes: - Remove pnpm from requirements section - Replace all pnpm install commands with npm ci - Remove pnpm-specific build approval instructions - Update Docker/Linux container instructions - Update all environment-specific setup instructions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
## [2.40.2](v2.40.1...v2.40.2) (2025-11-18) ### Bug Fixes * **docs:** remove remaining pnpm references from README.ja.md ([95fef1e](95fef1e)), closes [#104](#104)
|
🎉 This PR is included in version 2.40.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
pnpmを完全に削除し、npmに統一しました。これにより、ローカル開発環境とエンドユーザー環境で同じパッケージマネージャーを使用できるようになりました。
Changes
Removed Files
pnpm-lock.yaml- pnpmロックファイルpnpm-workspace.yaml- pnpmワークスペース設定.npmrc- pnpm workspace設定Modified Files
package.json (root)
packageManagerフィールドを削除pnpmセクションを削除mcp-server/package.json
prepublishOnly:pnpm run test:ci→npm run test:citest:nounity:pnpm run test:integration→npm run test:integrationpnpmセクションを削除README.md
pnpm install --frozen-lockfile→npm cipnpm build approvalの記述を削除package-lock.json
npm installで生成（809パッケージ）Verification
Benefits
Impact on Users
npm installまたはnpm ciを使用npx @akiojin/unity-mcp-server@latestで実行可能（変更なし）🤖 Generated with Claude Code
Summary by CodeRabbit
リリースノート
Documentation
Chores