fix(docs): complete pnpm to npm migration in Japanese README #105
Conversation
Complete the pnpm to npm migration by removing all pnpm references from the Japanese README. This fixes the incomplete migration in PR #104. Changes: - Remove pnpm from requirements section - Replace all pnpm install commands with npm ci - Remove pnpm-specific build approval instructions - Update Docker/Linux container instructions - Update all environment-specific setup instructions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
WalkthroughREADME.ja.mdのインストール手順を全面的に更新し、pnpmベースのコマンドをnpm ciに置き換え。基本ルール、Windows、WSL、Docker、macOSなど複数のセットアップセクション全体にわたって、依存関係管理コマンドの統一化を行いました。 Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - **基本ルール**: `.mcp.json` で `"command": "node"`（例: `node bin/unity-mcp-server serve`）を使う場合は、MCPサーバーを動かすマシン／コンテナ内で本パッケージが展開されているディレクトリで `pnpm install`（または `pnpm install --frozen-lockfile`）を実行してから MCP クライアントを起動します。 | ||
| - **pnpmでのビルド許可**: pnpm v10以降は依存のインストールスクリプトを許可制にしています。`better-sqlite3` がビルドできるよう、初回セットアップ時に `pnpm approve-builds better-sqlite3` を実行し、対話メニューで承認してください。citeturn1view0 | ||
| - **基本ルール**: `.mcp.json` で `"command": "node"`（例: `node bin/unity-mcp-server serve`）を使う場合は、MCPサーバーを動かすマシン／コンテナ内で本パッケージが展開されているディレクトリで `npm ci` を実行してから MCP クライアントを起動します。 |
There was a problem hiding this comment.
README.ja.md:198 now tells users to run npm ci from the mcp-server package directory, but this workspace only has package-lock.json at the repo root. Running npm ci inside mcp-server fails with npm ERR! ENOLOCK, so the documented setup steps for Windows/WSL/macOS and the Docker fallback will break. Update the instructions to run the install from the workspace root (e.g., npm ci --workspace=mcp-server in the repo root) or otherwise point users at the correct path.
Useful? React with 👍 / 👎.
|
🎉 This PR is included in version 2.40.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Complete the pnpm→npm migration by removing all remaining pnpm references from README.ja.md. This fixes the incomplete migration from PR #104.
Changes
pnpm install/pnpm install --frozen-lockfilewithnpm ciin all instructionspnpm approve-builds better-sqlite3)pnpm rebuildtonpm rebuildWhy
fix:type?This is a bug fix because:
Related
Test Plan
🤖 Generated with Claude Code
Summary by CodeRabbit
ドキュメンテーション