Implement response validation in http client binding#732
Merged
jfallows merged 26 commits intoJan 18, 2024
Conversation
attilakreiner
changed the title
attilakreiner
force-pushed
the
http-response-validation
branch
from
9020fc9 to
79bbc35
Compare
This reverts commit f43113a28939b6bdddf8d063a3df3c0b1b38ac24.
attilakreiner
force-pushed
the
http-response-validation
branch
from
f148130 to
6c74bc2
Compare
jfallows
requested changes
Jan 17, 2024
| } | ||
| } | ||
| return result; | ||
| } |
Contributor
There was a problem hiding this comment.
This method feels like it should be on OperationView instead of here.
Contributor
Author
There was a problem hiding this comment.
I managed to move both hasRepsonses methods out from here. It was necessary to create an OperationView and an OperationsView class (singular and plural). I think it makes sense, pls chk.
attilakreiner
force-pushed
the
http-response-validation
branch
from
ee0faa2 to
78aca86
Compare
jfallows
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change implements:
httpclientbindingFixes: #684