-
Notifications
You must be signed in to change notification settings - Fork 70
Implement response validation in http client binding #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jfallows
merged 26 commits into
aklivity:develop
from
attilakreiner:http-response-validation
Jan 18, 2024
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
733825c
WIP schema
attilakreiner b0e961e
WIP config
attilakreiner 183ed55
WIP match request
attilakreiner f1ff4d7
WIP resolve response
attilakreiner 79221ed
WIP resolve validator
attilakreiner b28f468
tmp
attilakreiner 30a7de0
Fix IntegerValidator, StringValidator
attilakreiner a4db1e8
WIP h1 validation
attilakreiner 2c29005
WIP invalid
attilakreiner 52a7318
cleanup
attilakreiner 507adb9
Revert "Fix IntegerValidator, StringValidator"
attilakreiner 415dad6
k3po rename
attilakreiner fc7f5c0
WIP generate openapi
attilakreiner 327a975
fix
attilakreiner 5cdc6c1
WIP k3po h2 valid test
attilakreiner 6c74bc2
WIP h1 spec
attilakreiner b9bbbed
fix h2 tests
attilakreiner 11ee224
cleanup
attilakreiner cabc997
fix
attilakreiner 099760e
fix OperationView, OperationsView
attilakreiner 83a3562
WIP response header validation: schema, config, builder, adapter
attilakreiner c399f39
WIP response header validation: openapi generator
attilakreiner 78aca86
WIP response header validation: resolve request
attilakreiner cb726a7
WIP response header validation: impl
attilakreiner 3aef600
WIP k3po http/1.1
attilakreiner 5c7c69d
WIP k3po h2
attilakreiner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
WIP generate openapi
- Loading branch information
commit fc7f5c0978c47250e10fc8b1e6f0131b32046e38
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
...main/java/io/aklivity/zilla/runtime/command/generate/internal/openapi/model/Response.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| /* | ||
| * Copyright 2021-2023 Aklivity Inc | ||
| * | ||
| * Licensed under the Aklivity Community License (the "License"); you may not use | ||
| * this file except in compliance with the License. You may obtain a copy of the | ||
| * License at | ||
| * | ||
| * https://www.aklivity.io/aklivity-community-license/ | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OF ANY KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations under the License. | ||
| */ | ||
| package io.aklivity.zilla.runtime.command.generate.internal.openapi.model; | ||
|
|
||
| public class Response | ||
| { | ||
| public Schema schema; | ||
| } |
22 changes: 22 additions & 0 deletions
22
...aklivity/zilla/runtime/command/generate/internal/openapi/model/ResponseByContentType.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| /* | ||
| * Copyright 2021-2023 Aklivity Inc | ||
| * | ||
| * Licensed under the Aklivity Community License (the "License"); you may not use | ||
| * this file except in compliance with the License. You may obtain a copy of the | ||
| * License at | ||
| * | ||
| * https://www.aklivity.io/aklivity-community-license/ | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OF ANY KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations under the License. | ||
| */ | ||
| package io.aklivity.zilla.runtime.command.generate.internal.openapi.model; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| public class ResponseByContentType | ||
| { | ||
| public Map<String, Response> content; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method feels like it should be on
OperationViewinstead of here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I managed to move both
hasRepsonsesmethods out from here. It was necessary to create anOperationViewand anOperationsViewclass (singular and plural). I think it makes sense, pls chk.