Skip to content

Update helm chart#901

Merged
jfallows merged 13 commits into
aklivity:developfrom
attilakreiner:helm2
Apr 10, 2024
Merged

Update helm chart#901
jfallows merged 13 commits into
aklivity:developfrom
attilakreiner:helm2

Conversation

@attilakreiner

Copy link
Copy Markdown
Contributor

Description

This change updates the zilla helm charts.

Fixes #884

Comment thread cloud/helm-chart/src/main/helm/zilla/values.yaml Outdated
@attilakreiner attilakreiner marked this pull request as ready for review April 9, 2024 16:08
@attilakreiner attilakreiner requested a review from vordimous April 9, 2024 16:08
Comment thread cloud/helm-chart/src/main/helm/zilla/templates/ingress.yaml Outdated
Comment thread cloud/helm-chart/src/main/helm/zilla/values.yaml
Comment thread cloud/helm-chart/src/main/helm/zilla/templates/ingress.yaml Outdated

@vordimous vordimous left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments and found one missing file that is needed.

Added secret-env.yaml.

Comment thread cloud/helm-chart/src/main/helm/zilla/templates/ingress.yaml Outdated
Comment thread cloud/helm-chart/src/main/helm/zilla/templates/tests/test-connection.yaml Outdated
Comment thread cloud/helm-chart/src/main/helm/zilla/templates/NOTES.txt Outdated
@attilakreiner attilakreiner requested a review from vordimous April 10, 2024 20:59
Comment thread cloud/helm-chart/pom.xml
Comment on lines +47 to +48
<exclude>src/main/helm/zilla/artifacthub-repo.yml</exclude>
<exclude>src/main/helm/zilla/**</exclude>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second one is sufficient to encompass the first one, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, true. Here's the fix: #912

@jfallows jfallows merged commit fe5cdea into aklivity:develop Apr 10, 2024
@attilakreiner attilakreiner deleted the helm2 branch April 11, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm chart QoL improvements

3 participants