tls client/server/echo handshake benchmark #990
Merged
Merged
Conversation
…artial data frame while computing crc32c value
jfallows
requested changes
May 1, 2024
Contributor
There was a problem hiding this comment.
Please remove buffers0 from the PR. 😄
| { | ||
| handler.accept(signalId); | ||
|
|
||
| return System.currentTimeMillis(); |
Contributor
There was a problem hiding this comment.
I think we don't need to return current time here, perhaps NO_CANCEL_ID instead since these are executed on stack and therefore not cancelable?
Same for other signalXXX methods.
jfallows
approved these changes
May 1, 2024
jfallows
approved these changes
May 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tlsclient/server/echohandshake benchmarkFixes #961