fix(InstantSearch): avoid useless search on addWidgets #3178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Deploy preview for algolia-instantsearch ready! Built with commit 4091cae https://deploy-preview-3178--algolia-instantsearch.netlify.com |
tkrugg
approved these changes
Oct 5, 2018
tkrugg
reviewed
Oct 5, 2018
francoischalifour
approved these changes
Oct 5, 2018
tkrugg
added a commit
to tkrugg/instantsearch.js
that referenced
this pull request
Oct 23, 2018
<a name=2.10.3></a> ## [2.10.3](algolia/instantsearch@v2.10.2...v2.10.3) (2018-10-23) ### Bug Fixes * **InstantSearch:** avoid useless search on addWidgets ([algolia#3178](algolia#3178)) ([961626d](algolia@961626d)) * **numericselector:** default value can be undefined ([algolia#3139](algolia#3139)) ([39d22f5](algolia@39d22f5)) ### Features * **utils:** add warn function ([algolia#3147](algolia#3147)) ([9de87bb](algolia@9de87bb))
francoischalifour
added a commit
that referenced
this pull request
Oct 29, 2018
<a name="2.10.3"></a> * **deps:** unpin production dependencies ([257ecb7](257ecb7)) * **getRefinements:** provide attributeName for type: query ([6a58b99](6a58b99)), closes [#3205](#3205) * **InstantSearch:** avoid useless search on addWidgets ([#3178](#3178)) ([961626d](961626d)) * **numericselector:** default value can be undefined ([#3139](#3139)) ([39d22f5](39d22f5)) * **utils:** add warn function ([#3147](#3147)) ([9de87bb](9de87bb))
francoischalifour
added a commit
that referenced
this pull request
Oct 29, 2018
<a name="2.10.3"></a> * **deps:** unpin production dependencies ([257ecb7](257ecb7)) * **getRefinements:** provide attributeName for type: query ([6a58b99](6a58b99)), closes [#3205](#3205) * **InstantSearch:** avoid useless search on addWidgets ([#3178](#3178)) ([961626d](961626d)) * **numericselector:** default value can be undefined ([#3139](#3139)) ([39d22f5](39d22f5)) * **utils:** add warn function ([#3147](#3147)) ([9de87bb](9de87bb))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current implementation of
addWidgetsalways trigger a search even without any widgets to add on InstantSearch. We should prevent this behaviour to avoid useless request each time a user calladdWidgetswithout anything.This issue pops out with a dynamic facetting use case (see example below) - we get an infinite loop because we always call
addWidgetswithout checking the length of the widgets to add. It should be the default behaviour.