chore(engine): pin Node and Yarn version #3228
Conversation
|
Deploy preview for algolia-instantsearch ready! Built with commit 40488bf https://deploy-preview-3228--algolia-instantsearch.netlify.com |
francoischalifour
changed the title
|
The motivation for doing this is avoid conflicts of integrity sha in yarn.lock. This what react-instantsearch seem to be doing. I'm not sure however how this is going to play out for user already using instantsearch.js. Would it make there update more painful? what if they have a more recent version of node and yarn, doesn't this constraint them to downgrade? |
.travis.yml
Outdated
| before_install: | ||
| - git config --global user.email "[email protected]" | ||
| - git config --global user.name "algobot" | ||
| - curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.10.1 |
There was a problem hiding this comment.
Those are not indented correctly (so are the two previous lines for some reason).
package.json
Outdated
| "vanilla" | ||
| ], | ||
| "engines": { | ||
| "node": "8.12.0", |
There was a problem hiding this comment.
just make sure that this doesn't end up in the package.json that gets pushed to npm, worst case, filter it out before publishing
There was a problem hiding this comment.
Let's remove it since it doesn't bring anything more than having it in .nvmrc.
There was a problem hiding this comment.
Not sure to understand your comment @Haroenv. Why it would have an impact on the published package? The engines attribute will only throw an error when a script is ran on that package specifically otherwise it's only a warning. It will only impact contributors.
@francoischalifour It does bring more value because not everyone is using nvm. For those who don't, the attribute is useful. One question remains on the strictness of the value. We can probably use a range rather than a pinned version. It will still enforce a value without bothering too much the contributors.
|
Since the PR was rebased it doesn't pin Yarn for us developers (in |
This also upgrades Node to 8.12.0.
upgraded [email protected] and [email protected].pinned yarn version in travis