Skip to content

Conversation

@francoischalifour
Copy link
Contributor

This is the equivalent of #3228 for the branch feat/3.0.

@algobot
Copy link
Contributor

algobot commented Oct 26, 2018

Deploy preview for algolia-instantsearch ready!

Built with commit 9b4b147

https://deploy-preview-3236--algolia-instantsearch.netlify.com

@francoischalifour francoischalifour requested a review from a team October 26, 2018 11:38
@Haroenv
Copy link
Contributor

Haroenv commented Oct 26, 2018

how come this can't be done my merging master into feat/3.0?

@francoischalifour
Copy link
Contributor Author

I was wondering at what point we want to separate the two branches. Is it too early?

I'm especially thinking about the commit 6006fe1 which is going to be annoying to merge with #3190.

@Haroenv
Copy link
Contributor

Haroenv commented Oct 26, 2018

It's the same for me, but with Vue InstantSearch I'm seeing annoyances now with having two completely separate branches

@francoischalifour
Copy link
Contributor Author

Makes sense. I will try to resolve conflicts from develop and treat this PR accordingly.

@francoischalifour
Copy link
Contributor Author

Handled in df23db1.

@francoischalifour francoischalifour deleted the chore/pin-yarn-and-node branch October 26, 2018 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants