[Crane] Adds Hilt to the project #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 20, 2020 11:22
chrisbanes
reviewed
Oct 23, 2020
Crane/app/src/main/java/androidx/compose/samples/crane/data/DestinationsLocalDataSource.kt
Show resolved
Hide resolved
Crane/app/src/main/java/androidx/compose/samples/crane/details/DetailsViewModel.kt
Outdated
Show resolved
Hide resolved
Crane/app/src/main/java/androidx/compose/samples/crane/home/MainViewModel.kt
Outdated
Show resolved
Hide resolved
Crane/app/src/main/java/androidx/compose/samples/crane/details/DetailsActivity.kt
Outdated
Show resolved
Hide resolved
Crane/app/src/main/java/androidx/compose/samples/crane/details/DetailsActivity.kt
Outdated
Show resolved
Hide resolved
chrisbanes
approved these changes
Oct 23, 2020
Closed
chrisbanes
added a commit
that referenced
this pull request
Oct 28, 2020
* [Jetsnack] Cart implementation * [Jetsnack] Reuse Quantity Selector * [Jetsnack] Reuse Destination Bar * [Jetsnack] Add Inspired By Section to Cart * [Jetsnack] Add Checkout Bar to cart * [Jetsnack] Fix Spotless issues * [Jetsnack] Fix review comments * [Jetsnack] Fix review comments * Update to snapshot 6922857. * [Jetsurvey] Bump to alpha06 * [Owl] Update to snapshot 6922857. * [JetChat] Update to snapshot 6922857 * [Rally] Update to snapshot 6922857 * [Jetcaster] Update to snapshot 6922857. * Removes unncessary elevation param * [Crane] Update to 6922857 snapshot (#246) * [Owl] Replace elevation overlay workaround with AmbientElevationOverlay. * [Jetchat] Replace elevation overlay workaround with AmbientElevationOverlay * [Jetsurvey] Redesigned next/prev buttons * [Jetsurvey] Redesigned progress indicator * [Jetsurvey] Adding elevation to the action bar * [Jetsurvey] Capitalising strings * [Jetsurvey] Question title redesigned * [Jetsurvey] Removing unused composable * [Jetsurvey] Removing the column usage in progress indicator * [Crane] Adds Hilt to the project (#237) * [JetNews] bump to alpha06 (#258) * [JetNews] bump to alpha06 * Fix unused modifier on BookmarkButton * Update all samples to AGP 4.2.0-alpha15 * Turn on allWarningsAsErrors in Jetsurvey * Tidy up gradle.properties We now have parallel compilation, caching and on-demand configuration enabled on all projects * Disable Jetifier where possible Only Crane requires Jetifier becuase it uses the Google Maps SDK. * Update all projects to ktlint 0.39.0 * Update snapshot URL * Update to Compose 1.0.0-alpha06 Co-authored-by: Jolanda Verhoef <[email protected]> Co-authored-by: Nick Butcher <[email protected]> Co-authored-by: Nick Butcher <[email protected]> Co-authored-by: Florina Muntenescu <[email protected]> Co-authored-by: Jose Alcerreca <[email protected]> Co-authored-by: Jolanda Verhoef <[email protected]> Co-authored-by: Jose Alcérreca <[email protected]> Co-authored-by: Florina Muntenescu <[email protected]> Co-authored-by: Manuel Vivo <[email protected]> Co-authored-by: Sean McQuillan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
viewModel()function used in Compose code gets the default ViewModelFactory created by Hilt with the@ViewModelInjectannotation.