Skip to content

[Crane] Adds Hilt to the project #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manuelvicnt merged 12 commits into from
Oct 27, 2020
Merged

[Crane] Adds Hilt to the project #237

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ffb504f
[Crane] Adds Hilt to the project
Oct 19, 2020
9b515d6
[Crane] Adds DetailsViewModel with AssistedInjection
Oct 20, 2020
39cba7d
[Crane] Removes flakiness from the test
Oct 20, 2020
2e6ea79
[Crane] Adds Hilt to the README
Oct 20, 2020
61504a7
[Crane] Makes tests more deterministic
Oct 20, 2020
fa4d177
[Crane] Removes year2020 singleton
Oct 20, 2020
74a83bc
[Crane] Adds comments clarifyng singletons
Oct 20, 2020
c5bef7e
Merge branch 'dev_alpha06' into mv/crane_hilt
Oct 23, 2020
8992435
[Crane] Declares explicit types and Views don't handle nulls
Oct 23, 2020
c2a2391
[Crane] Use Unconfined to avoid flaky tests
Oct 23, 2020
666134c
Merge branch 'dev_alpha06' into mv/crane_hilt
Oct 27, 2020
2637b7e
[Crane] Reverts gradle-wrapper properties
Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Crane] Adds comments clarifyng singletons
  • Loading branch information
Manuel Vivo committed Oct 20, 2020
commit 74a83bca65296368e8a3de42bedebfa718ce08b1
6 changes: 4 additions & 2 deletions Crane/app/src/androidTest/java/androidx/compose/samples/crane/di/TestDispatchersModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,14 @@

package androidx.compose.samples.crane.di

import android.os.AsyncTask
import dagger.Module
import dagger.Provides
import dagger.hilt.InstallIn
import dagger.hilt.android.components.ApplicationComponent
import kotlinx.coroutines.CoroutineDispatcher
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.asCoroutineDispatcher

@OptIn(ExperimentalCoroutinesApi::class)
@Module
Expand All @@ -33,5 +34,6 @@ class TestDispatchersModule {

@Provides
@DefaultDispatcher
fun provideDefaultDispatcher(): CoroutineDispatcher = Dispatchers.Unconfined
fun provideDefaultDispatcher(): CoroutineDispatcher =
AsyncTask.THREAD_POOL_EXECUTOR.asCoroutineDispatcher()
}
6 changes: 6 additions & 0 deletions Crane/app/src/main/java/androidx/compose/samples/crane/data/DatesLocalDataSource.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,18 @@

package androidx.compose.samples.crane.data

import androidx.compose.samples.crane.calendar.model.CalendarDay
import androidx.compose.samples.crane.calendar.model.CalendarMonth
import androidx.compose.samples.crane.calendar.model.DayOfWeek
import javax.inject.Inject
import javax.inject.Singleton

typealias CalendarYear = List<CalendarMonth>

/**
* Annotated with Singleton because [CalendarDay] contains mutable state.
*/
@Singleton
class DatesLocalDataSource @Inject constructor() {

private val january2020 = CalendarMonth(
Expand Down
4 changes: 3 additions & 1 deletion Crane/app/src/main/java/androidx/compose/samples/crane/data/DatesRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ import kotlinx.coroutines.withContext
import javax.inject.Inject
import javax.inject.Singleton

// Marked as Singleton as it contains mutable state
/**
* Annotated with Singleton because [DatesSelectedState] contains mutable state.
*/
@Singleton
class DatesRepository @Inject constructor(
datesLocalDataSource: DatesLocalDataSource,
Expand Down
3 changes: 3 additions & 0 deletions Crane/app/src/main/java/androidx/compose/samples/crane/data/DestinationsLocalDataSource.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ import javax.inject.Singleton

private const val DEFAULT_IMAGE_WIDTH = "250"

/**
* Annotated with Singleton as the class created a lot of objects.
*/
@Singleton
class DestinationsLocalDataSource @Inject constructor() {

Expand Down