Delete deprecated inventory plugin #902
Conversation
…cumentation as well as inventory plugin tests
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 18s |
| tombstone: | ||
| removal_version: 6.0.0 | ||
| warning_text: >- | ||
| The k8s inventory plugin has been deprecated and |
There was a problem hiding this comment.
I am getting the following sanity test error:
ERROR: Found 1 runtime-metadata issue(s) which need to be resolved:
ERROR: meta/runtime.yml:0:0: The tombstone removal_version ('6.0.0') must not be after the current version for dictionary value @ data['plugin_routing']['inventory']['k8s']['tombstone']['removal_version']. Got '6.0.0'
Do we need to wait until after 6.0.0 is release before we change deprecation: to tombstone:?
There was a problem hiding this comment.
To have it passed, you need to put a version like 6.0.0-dev0 in the galaxy.yaml as I did in the #867
Ideally, to complete ACA-2407 and as the preparation to ACA-2406 I recommend following:
- merge Drop version ansible-core 2.15 and python 3.9 ansible-network/github_actions#171
- merge Update ansible-lint action in workflow ansible-network/github_actions#169
- rebase to Initial update to 6.0.0-dev0: remove support of ansible-core<2.16.0 and k8s inventory plugin #867 and merdge
/att @gravesm as the reporter of ACA-2407 and one of repo maintainer.
ps: I can help with the #867 and associated CI issues, if any, You can see that I have some contributions over the last year
There was a problem hiding this comment.
| @@ -0,0 +1,4 @@ | |||
| --- | |||
| major_changes: | |||
There was a problem hiding this comment.
Is this the correct category of change? Should it be breaking_changes or minor_changes instead?
There was a problem hiding this comment.
The change type here is breaking_changes
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 21s |
|
It's the same in general as #867 |
Closing this since this is a duplicate of the above PR. |
3 participants
Resolves #570 and Jira ACA-2407
COMPONENT NAME
kubernetes/core/plugins/inventory/k8s.py