Skip to content

Delete deprecated inventory plugin #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
beeankha wants to merge 3 commits into from
Closed

Delete deprecated inventory plugin #902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbbe903
First pass of deleting inventory plugin and associated mentions in do…
beeankha Apr 21, 2025
c9c1471
Update deprecation warning to tombstone entry
beeankha Apr 21, 2025
d68ad9c
Add changelog file
beeankha Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,6 @@ Name | Description
--- | ---
kubernetes.core.k8s_config_resource_name|Generate resource name for the given resource of type ConfigMap, Secret

### Inventory plugins
Name | Description
--- | ---
[kubernetes.core.k8s](https://github.com/ansible-collections/kubernetes.core/blob/main/docs/kubernetes.core.k8s_inventory.rst)|Kubernetes (K8s) inventory source

### Lookup plugins
Name | Description
--- | ---
Expand Down
4 changes: 4 additions & 0 deletions changelogs/fragments/20250421-remove_k8s_inventory_plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
major_changes:
Copy link
Contributor Author

@beeankha beeankha Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the correct category of change? Should it be breaking_changes or minor_changes instead?

Copy link
Contributor

@abikouo abikouo Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change type here is breaking_changes

- k8s - Remove ``kubernetes.core.k8s`` inventory plugin
(https://github.com/ansible-collections/kubernetes.core/pull/902).
88 changes: 0 additions & 88 deletions docs/docsite/rst/kubernetes_scenarios/k8s_inventory.rst
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion docs/docsite/rst/scenario_guide.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,5 @@ To get started, please select one of the following topics.
:maxdepth: 1

kubernetes_scenarios/k8s_intro
kubernetes_scenarios/k8s_inventory
kubernetes_scenarios/k8s_scenarios

2 changes: 1 addition & 1 deletion meta/runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ plugin_routing:
openshift:
redirect: community.okd.openshift
k8s:
deprecation:
tombstone:
removal_version: 6.0.0
warning_text: >-
The k8s inventory plugin has been deprecated and
Copy link
Contributor Author

@beeankha beeankha Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting the following sanity test error:

ERROR: Found 1 runtime-metadata issue(s) which need to be resolved:
ERROR: meta/runtime.yml:0:0: The tombstone removal_version ('6.0.0') must not be after the current version for dictionary value @ data['plugin_routing']['inventory']['k8s']['tombstone']['removal_version']. Got '6.0.0'

Do we need to wait until after 6.0.0 is release before we change deprecation: to tombstone:?

Copy link
Contributor

@yurnov yurnov Apr 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To have it passed, you need to put a version like 6.0.0-dev0 in the galaxy.yaml as I did in the #867

Ideally, to complete ACA-2407 and as the preparation to ACA-2406 I recommend following:

/att @gravesm as the reporter of ACA-2407 and one of repo maintainer.

ps: I can help with the #867 and associated CI issues, if any, You can see that I have some contributions over the last year

Copy link
Contributor Author

@beeankha beeankha Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yurnov thanks so much for listing this all out. The two github_actions PRs have been merged; there is a merge conflict in #867, please let me know if you need any help with it.

Once we get the conflict sorted out and the CI re-run, we can take another look at that PR.

Expand Down
Loading
Loading