Skip to content

Bugfix: fix unit-source for pre-release of ansible-core 2.20 (devel and milestone branch) #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
softwarefactory-project-zuul merged 4 commits into from
Apr 24, 2025
Merged

Bugfix: fix unit-source for pre-release of ansible-core 2.20 (devel and milestone branch) #903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4088c2b
empty commit to trigger CI
yurnov Apr 23, 2025
4ad19f9
ensure string type, as suggested by @sivel
yurnov Apr 24, 2025
8a9ac37
test commit to find type of warnings
yurnov Apr 24, 2025
197789a
remove debug output
yurnov Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/unit/module_utils/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ def test_warn_on_k8s_version(monkeypatch, stdin, capfd):
assert return_value.get("warnings") is not None
warnings = return_value["warnings"]
assert len(warnings) == 1
assert "kubernetes" in warnings[0]
assert MINIMAL_K8S_VERSION in warnings[0]
assert "kubernetes" in str(warnings[0])
assert MINIMAL_K8S_VERSION in str(warnings[0])


dependencies = [
Expand Down
8 changes: 4 additions & 4 deletions tests/unit/module_utils/test_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,8 @@ def test_service_create_resource_warnings(
result, warnings = svc.create(Mock(), pod_definition)

assert result == mock_pod_resource_instance.to_dict()
assert warnings[0] == "test warning 1"
assert warnings[1] == "test warning 2"
assert str(warnings[0]) == "test warning 1"
assert str(warnings[1]) == "test warning 2"


def test_service_create_resource_check_mode():
Expand Down Expand Up @@ -289,8 +289,8 @@ def test_service_apply_existing_resource_warnings(
)

assert result == mock_pod_resource_instance.to_dict()
assert warnings[0] == "test warning 1"
assert warnings[1] == "test warning 2"
assert str(warnings[0]) == "test warning 1"
assert str(warnings[1]) == "test warning 2"


def test_service_replace_existing_resource(
Expand Down
Loading