Bugfix: fix unit-source for pre-release of ansible-core 2.20 (devel and milestone branch)

[yurnov]

SUMMARY

CI fix for #904

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

tests/unit

ADDITIONAL INFORMATION

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/f09c13ef1d704317b10ac5ab46f9eb6f

✔️ ansible-galaxy-importer SUCCESS in 3m 17s
✔️ build-ansible-collection SUCCESS in 5m 27s

[sivel]

The units are failing to compare warnings[0] since the internal definition of what is stored in the warnings list is no longer a simple string, it's a serialization of an internal type. At a minimum using str(warnings[0]) may allow the comparison to work in 2.19 and before, as it will repr the dict for the string in comparison.

- assert "kubernetes" in warnings[0]
+ assert "kubernetes" in str(warnings[0])

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d307a4dc2eb2406fb786194be54d7986

✔️ ansible-galaxy-importer SUCCESS in 3m 17s
✔️ build-ansible-collection SUCCESS in 5m 24s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4ea32231a9dd4681b7cba1d1616fdbbb

✔️ ansible-galaxy-importer SUCCESS in 3m 36s
✔️ build-ansible-collection SUCCESS in 5m 24s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/535500ae70de40de98e9e8fdda6e45f4

✔️ ansible-galaxy-importer SUCCESS in 3m 25s
✔️ build-ansible-collection SUCCESS in 5m 21s

[yurnov]

The units are failing to compare warnings[0] since the internal definition of what is stored in the warnings list is no longer a simple string, it's a serialization of an internal type. At a minimum using str(warnings[0]) may allow the comparison to work in 2.19 and before, as it will repr the dict for the string in comparison.

- assert "kubernetes" in warnings[0]
+ assert "kubernetes" in str(warnings[0])

Thanks a lot for your support

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/cba13e8844bf488e87f632f054415dc4

✔️ ansible-galaxy-importer SUCCESS in 3m 16s
✔️ build-ansible-collection SUCCESS in 5m 28s

[yurnov]

@gravesm, probably it's worth backporting this PR to stable-5 and stable-3

[patchback]

Backport to stable-3: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply d4fc22c on top of patchback/backports/stable-3/d4fc22c74e9c90ecfc4313166fb678734b794244/pr-903

Backporting merged PR #903 into main

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/ansible-collections/kubernetes.core.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/stable-3/d4fc22c74e9c90ecfc4313166fb678734b794244/pr-903 upstream/stable-3

4. Now, cherry-pick PR Bugfix: fix unit-source for pre-release of ansible-core 2.20 (devel and milestone branch) #903 contents into that branch:

   $ git cherry-pick -x d4fc22c74e9c90ecfc4313166fb678734b794244

   If it'll yell at you with something like fatal: Commit d4fc22c74e9c90ecfc4313166fb678734b794244 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x d4fc22c74e9c90ecfc4313166fb678734b794244

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Bugfix: fix unit-source for pre-release of ansible-core 2.20 (devel and milestone branch) #903 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/stable-3/d4fc22c74e9c90ecfc4313166fb678734b794244/pr-903

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

[patchback]

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/d4fc22c74e9c90ecfc4313166fb678734b794244/pr-903

Backported as #909

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.