accounts db/refactor accounts db test - convert test_full_clean_refcount #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoranYi
changed the title
Author
|
The actual change is in the last commit. |
brooksprumo
reviewed
Apr 15, 2024
brooksprumo
left a comment
brooksprumo
left a comment
There was a problem hiding this comment.
Please re-request a review once the dependent PRs have been merged and this PR has been rebased.
HaoranYi
changed the title
HaoranYi
force-pushed
the
accounts-db/refactor_accounts_db_test4
branch
from
092db14 to
fdcc714
Compare
Author
|
No code changes. Rebase on top of master to pick up #786. |
brooksprumo
reviewed
Apr 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #814 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 851 851
Lines 231758 231646 -112
=========================================
- Hits 189695 189587 -108
+ Misses 42063 42059 -4 |
michaelschem
pushed a commit
to michaelschem/agave
that referenced
this pull request
Apr 20, 2024
…unt (anza-xyz#814) * add full_clean_refcount tests for both account storage formats * keep code comments * fix test to match with code comments --------- Co-authored-by: HaoranYi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Continued on #786
Summary of Changes
Fixes #