Skip to content

accounts db/refactor accounts db test - convert test_full_clean_refcount #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HaoranYi merged 3 commits into from
Apr 17, 2024
Merged

accounts db/refactor accounts db test - convert test_full_clean_refcount #814

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdcc714
add full_clean_refcount tests for both account storage formats
Apr 15, 2024
45dee85
keep code comments
Apr 17, 2024
479463c
fix test to match with code comments
Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add full_clean_refcount tests for both account storage formats
  • Loading branch information
HaoranYi committed Apr 17, 2024
commit fdcc71432f52c8b8698b74b84f5fdd81d0cea99e
32 changes: 11 additions & 21 deletions accounts-db/src/accounts_db.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12642,7 +12642,7 @@ pub mod tests {
}
);

fn do_full_clean_refcount(store1_first: bool, store_size: u64) {
fn do_full_clean_refcount(mut accounts: AccountsDb, store1_first: bool, store_size: u64) {
let pubkey1 = Pubkey::from_str("My11111111111111111111111111111111111111111").unwrap();
let pubkey2 = Pubkey::from_str("My22211111111111111111111111111111111111111").unwrap();
let pubkey3 = Pubkey::from_str("My33311111111111111111111111111111111111111").unwrap();
Expand All @@ -12663,10 +12663,7 @@ pub mod tests {
let zero_lamport_account = AccountSharedData::new(zero_lamport, data_size, &owner);

let mut current_slot = 0;
let accounts = AccountsDb {
file_size: store_size,
..AccountsDb::new_single_for_tests()
};
accounts.file_size = store_size;

// A: Initialize AccountsDb with pubkey1 and pubkey2
current_slot += 1;
Expand Down Expand Up @@ -12749,24 +12746,17 @@ pub mod tests {
assert_eq!(accounts.ref_count_for_pubkey(&pubkey3), 0);
}

#[test]
fn test_full_clean_refcount() {
solana_logger::setup();

// Setup 3 scenarios which try to differentiate between pubkey1 being in an
// Available slot or a Full slot which would cause a different reset behavior
// when pubkey1 is cleaned and therefore cause the ref count to be incorrect
// preventing a removal of that key.
//
// do stores with a 4mb size so only 1 store is created per slot
do_full_clean_refcount(false, 4 * 1024 * 1024);
define_accounts_db_test!(test_full_clean_refcount_no_first_4m, |accounts| {
do_full_clean_refcount(accounts, false, 4 * 1024 * 1024);
});

// do stores with a 4k size and store pubkey1 first
do_full_clean_refcount(false, 4096);
define_accounts_db_test!(test_full_clean_refcount_no_first_4k, |accounts| {
do_full_clean_refcount(accounts, false, 4 * 1024);
});

// do stores with a 4k size and store pubkey1 2nd
do_full_clean_refcount(true, 4096);
}
define_accounts_db_test!(test_full_clean_refcount_first_4k, |accounts| {
do_full_clean_refcount(accounts, false, 4 * 1024);
});

#[test]
fn test_clean_stored_dead_slots_empty() {
Expand Down