-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add get_bit to BooleanBufferBuilder #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
=======================================
Coverage 82.44% 82.44%
=======================================
Files 168 168
Lines 47347 47365 +18
=======================================
+ Hits 39033 39052 +19
+ Misses 8314 8313 -1
Continue to review full report at Codecov.
|
Dandandan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The tests look good as well
|
How many approvers does one need to get a pr merged? |
We don't have a minimum reviewers requirement. The PRs will be merged after some common sense judgement, based on the complexity of the changes and giving other reviewers time to review and comment. As the change is small and not really controversial I just merged it |
|
I plan to backport this change to 5.3.0 (eta in about two weeks time) |
* Add get_bit to BooleanBufferBuilder * fix clippy
|
Backport in #699. I plan to make 5.3.0 release candidate around Aug 27 |
* Add get_bit to BooleanBufferBuilder * fix clippy Co-authored-by: Boaz <[email protected]>
Which issue does this PR close?
Ref apache/datafusion#342
Ref apache/datafusion#240
Rationale for this change
Described in the DataFusion issue. To make BooleanBufferBuilder useable as a bit vector within DataFusion code I needed this api exposed as well.
What changes are included in this PR?
Are there any user-facing changes?