Left join could use bitmap for left join instead of Vec<bool> #884
Conversation
|
The build will fail due to the fact it relies on an new api to Please let me know what If you need anything else on my side to make this happen. Thanks! (cc @alamb that corresponded with me on the previous PR) |
Dandandan
left a comment
Dandandan
left a comment
There was a problem hiding this comment.
Looks good to me (if it's integrated to arrow)👍 thanks @boazberman , nice addition!
|
FYI assuming we merge + backport apache/arrow-rs#693 (which seems likely) it would be available in arrow-rs 5.3.0 (target release date in about 2 weeks time). Thank you very much for sticking with this @boazberman |
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks very nice ❤️ -- thank you @boazberman
|
Nice work @boazberman ! I wish there is automated benchmark report against master on every PR so we get to see the sweet performance gain number :) I vaguely remember ursalabs built a tool for this particular use-case for the main arrow repo. |
alamb
added
the
waiting-on-upstream
houqp
removed
the
waiting-on-upstream
|
Marking PRs that haven't had activity in over a month as 'stale-pr' to help me filter the list. Please remove the label or let me know if "stale" is not the correct designation |
|
Closing a seemingly stale PR -- please reopen if that was a mistake. |
* remove xfail from passing tests * update xfail cmoment for datetime_s * document upstream issue for timestamp[s] xfail test
4 participants
Which issue does this PR close?
Depends on: apache/arrow-rs#693
Closes #240 .
This is a new version (arrow native) of: #342 (which is also me, from the company account)
Rationale for this change
Described in the issue.
What changes are included in this PR?
Described in the issue.
Are there any user-facing changes?
No