Revert "Minor: remove filter code deprecated in 2023 (#7554)" #7583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 71b4b0f.
This was referenced Jun 1, 2025
etseidl
pushed a commit
that referenced
this pull request
Jun 27, 2025
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Reapplies #7554 - Reverts #7583 # Rationale for this change - This code is long dead, see #7554 I had to revert the original change to avoid a breaking API change # What changes are included in this PR? Reapply the change from #7554 # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!--- If there are any breaking changes to public APIs, please call them out. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 71b4b0f.
Which issue does this PR close?
Rationale for this change
Technically speaking #7554 is a breaking API change (even though I expect its impacts to be minimal) and thus should not be included until the next major release
What changes are included in this PR?
Revert #7554 (I will re-create it for the next major release)
Are there any user-facing changes?