Minor: Remove filter code deprecated in 2023 (try 2) #7584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
added
the
next-major-release
alamb
changed the title
alamb
force-pushed
the
alamb/revert_revert_filter_removal
branch
from
7e977c5 to
2b2fa79
Compare
mbrobbel
approved these changes
Jun 2, 2025
etseidl
approved these changes
Jun 2, 2025
Dandandan
approved these changes
Jun 2, 2025
Contributor
Dandandan
left a comment
Dandandan
left a comment
There was a problem hiding this comment.
Sorry, I saw I merged it earlier :/
It looks good 💯
Contributor
Author
|
no worries -- I think we are all just doing the best we can |
Contributor
|
Second time's the charm 😄 Thanks @alamb! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I had to revert the original change to avoid a breaking API change
What changes are included in this PR?
Reapply the change from #7554
Are there any user-facing changes?