Fix clippy for Rust 1.88 release #7797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parquet
alamb
commented
Jun 26, 2025
| 1., | ||
| unsafe { std::mem::transmute(-1_i32) }, | ||
| unsafe { std::mem::transmute(i32::MAX) } | ||
| unsafe { |
Contributor
Author
There was a problem hiding this comment.
I couldn't remove the transmute here yet because the MSRV is too low (needs to be 1.87 before we can remove the transmute)
etseidl
approved these changes
Jun 27, 2025
Contributor
Author
|
Thanks for the review @etseidl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
1.88upgrade #7796Rationale for this change
CI started failing after clippy got more strict
What changes are included in this PR?
Apply clippy fixes
Are these changes tested?
Yes by CI
Are there any user-facing changes?
No