chore: Add rust-toolchain.toml to ensure consistent toolchain version #7972

EricccTaiwan · 2025-07-21T15:49:58Z

Which issue does this PR close?

None.

Rationale for this change

Without a fixed toolchain, contributors may use different Rust versions, leading to inconsistent Clippy lints or build errors (e.g., from renamed lints). This change ensures that the project builds consistently across environments.

What changes are included in this PR?

Add a rust-toolchain.toml file to pin the Rust toolchain to the stable channel.

Are these changes tested?

This change affects toolchain configuration and does not modify runtime code. Behavior is implicitly tested via CI builds, which will now consistently use the pinned toolchain.

Are there any user-facing changes?

No.

alamb · 2025-07-21T23:02:10Z

THANK YOU @EricccTaiwan -- this is super helpful

alamb · 2025-07-21T23:03:11Z

rust-toolchain.toml

What do you think of adding a specific release here like https://github.com/apache/datafusion/blob/70e7eb3aaef221c8fefe2eee6198e9a61d68bc0f/rust-toolchain.toml#L22

1.88

That will prevent random failure when new stable releases are released

What do you think of adding a specific release here like https://github.com/apache/datafusion/blob/70e7eb3aaef221c8fefe2eee6198e9a61d68bc0f/rust-toolchain.toml#L22

1.88

That will prevent random failure when new stable releases are released

Makes sense. Using 1.88 avoids random breakage, though it means running rustup manually.
I'm okay with both. What do you prefer?

I think it is preferable to have to manually bump it to avoid CI randomly breaking when a new rust version is released.

For example Fix clippy for Rust 1.88 release #7797

EricccTaiwan · 2025-07-22T03:00:50Z

By the way, would it make sense to also add components = ["rustfmt", "clippy"] like in DataFusion?
https://github.com/apache/datafusion/blob/70e7eb3aaef221c8fefe2eee6198e9a61d68bc0f/rust-toolchain.toml#L23

alamb · 2025-07-22T21:37:28Z

By the way, would it make sense to also add components = ["rustfmt", "clippy"] like in DataFusion? https://github.com/apache/datafusion/blob/70e7eb3aaef221c8fefe2eee6198e9a61d68bc0f/rust-toolchain.toml#L23

I am not sure

alamb

Thanks @EricccTaiwan -- think this looks great to me

EricccTaiwan · 2025-07-23T14:37:23Z

By the way, would it make sense to also add components = ["rustfmt", "clippy"] like in DataFusion? https://github.com/apache/datafusion/blob/70e7eb3aaef221c8fefe2eee6198e9a61d68bc0f/rust-toolchain.toml#L23

I am not sure

Just thought it might be helpful for consistency, and possibly more contributor-friendly too -- especially for folks who rely on cargo fmt and cargo clippy out of the box.
But I’m good either way. 👍

alamb · 2025-07-23T16:06:23Z

Hmm, looks like the CI jobs will need to be updated to account for the new toolchain somehow

EricccTaiwan · 2025-07-23T16:19:06Z

Hmm, looks like the CI jobs will need to be updated to account for the new toolchain somehow

Yes, I see -- I can give it a try to modify the CI part.
By the way, is there a way for me to test the CI on my own fork? Or does it only run on the upstream repo?

alamb · 2025-07-23T21:34:44Z

Hmm, looks like the CI jobs will need to be updated to account for the new toolchain somehow

Yes, I see -- I can give it a try to modify the CI part. By the way, is there a way for me to test the CI on my own fork? Or does it only run on the upstream repo?

I think can make (another) PR into your own fork to test the CI

This file ensures that contributors and CI use the same Rust toolchain, preventing version mismatch issues and improving reproducibility. Signed-off-by: Cheng-Yang Chou <[email protected]>

EricccTaiwan · 2025-07-26T13:22:54Z

Hmm, looks like the CI jobs will need to be updated to account for the new toolchain somehow

Yes, I see -- I can give it a try to modify the CI part. By the way, is there a way for me to test the CI on my own fork? Or does it only run on the upstream repo?

I think can make (another) PR into your own fork to test the CI

I'm a bit confused — on my fork, CI only seems to run on the main branch. When I sync with upstream, it works fine, but creating a new branch (like this PR) doesn’t trigger CI at all.
And just to confirm: on the upstream repo, do CI jobs always require approval before they start running?

Edit: Cuz I need CI to show me what needs changing. 😢

alamb · 2025-07-28T14:57:06Z

I'm a bit confused — on my fork, CI only seems to run on the main branch. When I sync with upstream, it works fine, but creating a new branch (like this PR) doesn’t trigger CI at all.
And just to confirm: on the upstream repo, do CI jobs always require approval before they start running?

CI jobs on this (the upstream) repo need approval for first time contributors. Once we have merged a PR from you then the CI starts automatically on subsequent PRs

alamb · 2025-08-07T12:40:56Z

Here is an example of what happens without this PR:

New clippy is released, and CI tests start failing
First person to notice needs to make a PR to fix it
Fix new clippy lints from Rust 1.89 #8078

alamb · 2025-08-07T14:14:42Z

Since the new upgrade just caused me annoyance I am going to try and push this PR through (It will be easier for me as I can trigger CI). Thanks you @EricccTaiwan

EricccTaiwan · 2025-08-07T14:18:00Z

Since the new upgrade just caused me annoyance I am going to try and push this PR through (It will be easier for me as I can trigger CI). Thanks you @EricccTaiwan

Hi @alamb , I’ve been a bit busy lately, and this change looks a bit more involved than I can tackle right now.
I’m not sure how to move it forward at the moment, but I’m happy to help if there’s anything specific you need. Thanks!

alamb · 2025-08-07T14:24:28Z

Since the new upgrade just caused me annoyance I am going to try and push this PR through (It will be easier for me as I can trigger CI). Thanks you @EricccTaiwan

Hi @alamb , I’ve been a bit busy lately, and this change looks a bit more involved than I can tackle right now. I’m not sure how to move it forward at the moment, but I’m happy to help if there’s anything specific you need. Thanks!

No worries -- thank you for the help. I will get this one over the line. Than you for all your help so far

alamb · 2025-08-07T15:18:34Z

.github/actions/setup-builder/action.yaml


 name: Prepare Rust Builder
 description: 'Prepare Rust Build Environment'
-inputs:


I removed these parameters as almost all uses installed stable

alamb · 2025-08-07T15:19:29Z

.github/workflows/arrow.yml

-          target: wasm32-unknown-unknown,wasm32-wasip1
+      - name: Install wasm32 targets
+        run: |
+          rustup target add wasm32-unknown-unknown


This adds 4 seconds to the job:

alamb · 2025-08-07T15:21:48Z

.github/workflows/docs.yml

  docs:
    name: Rustdocs are clean
    runs-on: ubuntu-latest
-    strategy:


I think this is let over from a previous time when we checked docs on different configurations -- at the moment there is a single pair that is used, so I unparameterized this and made the version used explicit

This adds 9s to the job

alamb · 2025-08-12T21:38:01Z

Thanks again @EricccTaiwan -- since there has been no more comments on this PR I will merge it in

EricccTaiwan · 2025-08-13T02:37:53Z

Thanks again @EricccTaiwan -- since there has been no more comments on this PR I will merge it in

Thanks @alamb, for doing most of the work, lol!

alamb reviewed Jul 21, 2025

View reviewed changes

EricccTaiwan force-pushed the add-rust-toolchain branch from 6173a17 to 82c42da Compare July 22, 2025 10:17

alamb approved these changes Jul 22, 2025

View reviewed changes

chore: Add rust-toolchain.toml to ensure consistent toolchain version

f782ef9

This file ensures that contributors and CI use the same Rust toolchain, preventing version mismatch issues and improving reproducibility. Signed-off-by: Cheng-Yang Chou <[email protected]>

EricccTaiwan force-pushed the add-rust-toolchain branch from 82c42da to f782ef9 Compare July 26, 2025 13:13

alamb added the development-process Related to development process of arrow-rs label Aug 7, 2025

Merge remote-tracking branch 'apache/main' into add-rust-toolchain

4b229e8

Update toolchain setup

ed838ad

alamb added 7 commits August 7, 2025 10:24

fix

5a772bf

try 3

e04bb8a

revert

892c5a0

install

ac2b6ef

move

3a7decb

cleaup

1dd7e78

install targets

5b94123

alamb reviewed Aug 7, 2025

View reviewed changes

Merge remote-tracking branch 'apache/main' into add-rust-toolchain

8089db5

Update to 1.89

19b28ad

alamb mentioned this pull request Aug 7, 2025

Fix new clippy lints from Rust 1.89 #8078

Merged

Merge branch 'main' into add-rust-toolchain

2976c39

alamb merged commit c628435 into apache:main Aug 12, 2025
31 checks passed

EricccTaiwan deleted the add-rust-toolchain branch August 13, 2025 02:37

chore: Add rust-toolchain.toml to ensure consistent toolchain version #7972

chore: Add rust-toolchain.toml to ensure consistent toolchain version #7972

Uh oh!

Conversation

EricccTaiwan commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

alamb commented Jul 21, 2025

Uh oh!

alamb Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

EricccTaiwan Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

alamb Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

EricccTaiwan commented Jul 22, 2025

Uh oh!

alamb commented Jul 22, 2025

Uh oh!

alamb left a comment

Choose a reason for hiding this comment

Uh oh!

EricccTaiwan commented Jul 23, 2025

Uh oh!

alamb commented Jul 23, 2025

Uh oh!

EricccTaiwan commented Jul 23, 2025

Uh oh!

alamb commented Jul 23, 2025

Uh oh!

EricccTaiwan commented Jul 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alamb commented Jul 28, 2025

Uh oh!

alamb commented Aug 7, 2025

Uh oh!

alamb commented Aug 7, 2025

Uh oh!

EricccTaiwan commented Aug 7, 2025

Uh oh!

alamb commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alamb Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

alamb Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

alamb Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

alamb Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alamb commented Aug 12, 2025

Uh oh!

Uh oh!

EricccTaiwan commented Aug 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

EricccTaiwan commented Jul 21, 2025 •

edited

Loading

EricccTaiwan commented Jul 26, 2025 •

edited

Loading

alamb commented Aug 7, 2025 •

edited

Loading

alamb Aug 7, 2025 •

edited

Loading