Skip to content

implement cast_to_variant kernel to cast native types to VariantArray #8044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 6 commits into from
Aug 6, 2025
Merged

implement cast_to_variant kernel to cast native types to VariantArray #8044

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
23910cd
Add `cast_to_variant` kernel
alamb Aug 5, 2025
52e461d
Use normal `From` conversions
alamb Aug 5, 2025
a28f4bc
cleanup
alamb Aug 5, 2025
bc4f34d
fix typo
alamb Aug 6, 2025
330a68d
update comments
alamb Aug 6, 2025
764c027
Fix docs
alamb Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update comments
  • Loading branch information
@alamb
alamb committed Aug 6, 2025
commit 330a68d08268e004a286bb07ab3aacf5353b02e4
6 changes: 4 additions & 2 deletions parquet-variant-compute/src/cast_to_variant.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ pub fn cast_to_variant(input: &dyn Array) -> Result<VariantArray, ArrowError> {
let mut builder = VariantArrayBuilder::new(input.len());

let input_type = input.data_type();
// todo: use `downcast_primitive` to avoid the boilerplate and match more types
// todo: handle other types like Boolean, Strings, Date, Timestamp, etc.
match input_type {
DataType::Int8 => {
primitive_conversion!(Int8Type, input, builder);
Expand Down Expand Up @@ -107,7 +107,9 @@ pub fn cast_to_variant(input: &dyn Array) -> Result<VariantArray, ArrowError> {
Ok(builder.build())
}

// TODO add cast_with_options that allow specifying
// TODO do we need a cast_with_options to allow specifying conversion behavior,
// e.g. how to handle overflows, whether to convert to Variant::Null or return
// an error, etc. ?

#[cfg(test)]
mod tests {
Expand Down
Loading