Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typo
  • Loading branch information
alamb committed Aug 6, 2025
commit bc4f34d9c2ac74145f346ad212d9420ace15a01f
22 changes: 11 additions & 11 deletions parquet-variant-compute/src/cast_to_variant.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ use parquet_variant::Variant;

/// Convert the input array of a specific primitive type to a `VariantArray`
/// row by row
macro_rules! primtive_conversion {
macro_rules! primitive_conversion {
($t:ty, $input:expr, $builder:expr) => {{
let array = $input.as_primitive::<$t>();
for i in 0..array.len() {
Expand Down Expand Up @@ -69,34 +69,34 @@ pub fn cast_to_variant(input: &dyn Array) -> Result<VariantArray, ArrowError> {
// todo: use `downcast_primitive` to avoid the boilerplate and match more types
match input_type {
DataType::Int8 => {
primtive_conversion!(Int8Type, input, builder);
primitive_conversion!(Int8Type, input, builder);
}
DataType::Int16 => {
primtive_conversion!(Int16Type, input, builder);
primitive_conversion!(Int16Type, input, builder);
}
DataType::Int32 => {
primtive_conversion!(Int32Type, input, builder);
primitive_conversion!(Int32Type, input, builder);
}
DataType::Int64 => {
primtive_conversion!(Int64Type, input, builder);
primitive_conversion!(Int64Type, input, builder);
}
DataType::UInt8 => {
primtive_conversion!(UInt8Type, input, builder);
primitive_conversion!(UInt8Type, input, builder);
}
DataType::UInt16 => {
primtive_conversion!(UInt16Type, input, builder);
primitive_conversion!(UInt16Type, input, builder);
}
DataType::UInt32 => {
primtive_conversion!(UInt32Type, input, builder);
primitive_conversion!(UInt32Type, input, builder);
}
DataType::UInt64 => {
primtive_conversion!(UInt64Type, input, builder);
primitive_conversion!(UInt64Type, input, builder);
}
DataType::Float32 => {
primtive_conversion!(Float32Type, input, builder);
primitive_conversion!(Float32Type, input, builder);
}
DataType::Float64 => {
primtive_conversion!(Float64Type, input, builder);
primitive_conversion!(Float64Type, input, builder);
}
dt => {
return Err(ArrowError::CastError(format!(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a bunch of follow on tickets we can perhaps file as follow on work:

  1. Support for timestamps
  2. Support for string / binary arrays
  3. Support for various timestamps types

Expand Down