fix(mango): improve handling of unsatisfiable ranges in selectors
#4568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain configurations of unsatisfiable field ranges could cause
HTTP 500 because they are not handled, for example:
{"$and": [{"field": {"$eq": N}}, {"field": {"$gt": N}}]}
This makes `mango_idx_view:end_key/1` fail because there is no
clause to cover `[{'$gt',35,'$eq',35}]`, the value that the
selector becomes mapped to.
Similar field ranges are somewhat already handled by being mapped
to `empty` so this seems to be an oversight in the original
implementation. Consider the following case, which will not
crash on the contrary:
{"$and": [{"field": {"$gt": N}}, {"field": {"$eq": N}}]}
Add the missing function clauses to fix this problem.
Found by: random query generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain configurations of unsatisfiable field ranges could cause HTTP 500 because they are not handled, for example:
{"$and": [{"field": {"$eq": N}}, {"field": {"$gt": N}}]}This makes
mango_idx_view:end_key/1fail because there is no clause to cover[{'$gt',35,'$eq',35}], the value that the selector becomes mapped to.Similar field ranges are somewhat already handled by being mapped to
emptyso this seems to be an oversight in the original implementation. Consider the following case, which will not crash on the contrary:{"$and": [{"field": {"$gt": N}}, {"field": {"$eq": N}}]}Add the missing function clauses to fix this problem.
Checklist