Skip to content

fix(mango): improve handling of unsatisfiable ranges in selectors #4568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pgj wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(mango): improve handling of unsatisfiable ranges in selectors #4568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/mango/src/mango_idx_view.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,10 @@ range(_, _, LCmp, Low, HCmp, High) ->
% operators but its all straight forward once you figure out how
% we're basically just narrowing our logical ranges.

range({[{<<"$lt">>, Arg}]}, '$eq', N, '$eq', N) when
(N >= Arg)
->
empty;
range({[{<<"$lt">>, Arg}]}, LCmp, Low, HCmp, High) ->
case range_pos(Low, Arg, High) of
min ->
Expand Down Expand Up @@ -466,6 +470,10 @@ range({[{<<"$gte">>, Arg}]}, LCmp, Low, HCmp, High) ->
max ->
empty
end;
range({[{<<"$gt">>, Arg}]}, '$eq', N, '$eq', N) when
(Arg >= N)
->
empty;
range({[{<<"$gt">>, Arg}]}, LCmp, Low, HCmp, High) ->
case range_pos(Low, Arg, High) of
min ->
Expand Down