Skip to content

feat:Solving Circular Dependency in Dubbo-Go - #2576

Merged
DMwangnima merged 5 commits into
apache:mainfrom
FinalT:feat-internal
Jan 14, 2024
Merged

DMwangnima merged 5 commits into
apache:mainfrom
FinalT:feat-internal

Conversation

@FinalT

@FinalT FinalT commented Jan 12, 2024

Copy link
Copy Markdown
Member

refer #2565

@codecov-commenter

codecov-commenter commented Jan 12, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4f21a41) 47.82% compared to head (874063e) 47.54%.
Report is 4 commits behind head on main.

Files Patch % Lines
protocol/triple/triple.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2576      +/-   ##
==========================================
- Coverage   47.82%   47.54%   -0.28%     
==========================================
  Files         318      318              
  Lines       23436    23565     +129     
==========================================
- Hits        11208    11205       -3     
- Misses      11169    11300     +131     
- Partials     1059     1060       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread internal/internal.go Resolved
Comment thread internal/internal.go Resolved
Comment thread internal/internal.go Resolved
Comment thread internal/internal.go Resolved
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DMwangnima DMwangnima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DMwangnima
DMwangnima merged commit 2489243 into apache:main Jan 14, 2024
@FinalT
FinalT deleted the feat-internal branch February 1, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants