Skip to content

feat:add internal service extension - #2577

Merged
chickenlj merged 7 commits into
apache:mainfrom
FinalT:feat-service
Jan 26, 2024
Merged

chickenlj merged 7 commits into
apache:mainfrom
FinalT:feat-service

Conversation

@FinalT

@FinalT FinalT commented Jan 12, 2024

Copy link
Copy Markdown
Member

refer #2565 #2539
Provide extension points for internal service exposure,such as healthCheck, reflection and metadata in future
Cooperate with the internal module(#2576) to solve the circular dependency problem

@codecov-commenter

codecov-commenter commented Jan 13, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (2489243) 47.54% compared to head (a1da9e2) 47.46%.

❗ Current head a1da9e2 differs from pull request most recent head c5353a3. Consider uploading reports for the commit c5353a3 to get more accurate results

Files Patch % Lines
protocol/triple/health/healthServer.go 20.00% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2577      +/-   ##
==========================================
- Coverage   47.54%   47.46%   -0.08%     
==========================================
  Files         318      318              
  Lines       23571    23569       -2     
==========================================
- Hits        11206    11188      -18     
- Misses      11304    11319      +15     
- Partials     1061     1062       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread server/server.go Resolved
Comment thread server/server.go Resolved
Comment thread server/server.go Resolved
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@chickenlj chickenlj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj
chickenlj merged commit 2e54f26 into apache:main Jan 26, 2024
FoghostCn pushed a commit to FoghostCn/dubbo-go that referenced this pull request Jan 29, 2024
@FinalT
FinalT deleted the feat-service branch February 1, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants