Skip to content

Rename data_sequence_number to sequence_number in ManifestEntry #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HonahX merged 6 commits into from
Jul 11, 2024
Merged

Rename data_sequence_number to sequence_number in ManifestEntry #900

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aa5f82c
Rename data_sequence_number to sequence_number in ManifestEntry
soumya-ghosh Jul 6, 2024
585d4af
Rename _min_data_sequence_number to _min_sequence_number in ManifestW…
soumya-ghosh Jul 8, 2024
3988ee0
Rename min_data_sequence_number to min_sequence_number in pyiceberg.t…
soumya-ghosh Jul 8, 2024
aea36b8
Rename _min_data_sequence_number to _min_sequence_number in ManifestW…
soumya-ghosh Jul 8, 2024
55b9985
Fix comments and method name
soumya-ghosh Jul 9, 2024
32e0732
Fix variables in upstream code
soumya-ghosh Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix comments and method name
  • Loading branch information
@soumya-ghosh
soumya-ghosh committed Jul 10, 2024
commit 55b9985271d2ef5c32cd7ce61ed1d563b18f5290
4 changes: 2 additions & 2 deletions pyiceberg/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,8 +665,8 @@ def _inherit_from_manifest(entry: ManifestEntry, manifest: ManifestFile) -> Mani
if entry.snapshot_id is None:
entry.snapshot_id = manifest.added_snapshot_id

# in v1 tables, the data sequence number is not persisted and can be safely defaulted to 0
# in v2 tables, the data sequence number should be inherited iff the entry status is ADDED
# in v1 tables, the sequence number is not persisted and can be safely defaulted to 0
# in v2 tables, the sequence number should be inherited iff the entry status is ADDED
if entry.sequence_number is None and (manifest.sequence_number == 0 or entry.status == ManifestEntryStatus.ADDED):
entry.sequence_number = manifest.sequence_number

Expand Down
4 changes: 2 additions & 2 deletions pyiceberg/table/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1888,7 +1888,7 @@ def _open_manifest(
]


def _min_data_file_sequence_number(manifests: List[ManifestFile]) -> int:
def _min_sequence_number(manifests: List[ManifestFile]) -> int:
try:
return min(
manifest.min_sequence_number or INITIAL_SEQUENCE_NUMBER
Expand Down Expand Up @@ -1994,7 +1994,7 @@ def plan_files(self) -> Iterable[FileScanTask]:
self.table_metadata.schema(), self.row_filter, self.case_sensitive, self.options.get("include_empty_files") == "true"
).eval

min_sequence_number = _min_data_file_sequence_number(manifests)
min_sequence_number = _min_sequence_number(manifests)

data_entries: List[ManifestEntry] = []
positional_delete_entries = SortedList(key=lambda entry: entry.sequence_number or INITIAL_SEQUENCE_NUMBER)
Expand Down