Skip to content

Rename data_sequence_number to sequence_number in ManifestEntry #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HonahX merged 6 commits into from
Jul 11, 2024
Merged

Rename data_sequence_number to sequence_number in ManifestEntry #900

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aa5f82c
Rename data_sequence_number to sequence_number in ManifestEntry
soumya-ghosh Jul 6, 2024
585d4af
Rename _min_data_sequence_number to _min_sequence_number in ManifestW…
soumya-ghosh Jul 8, 2024
3988ee0
Rename min_data_sequence_number to min_sequence_number in pyiceberg.t…
soumya-ghosh Jul 8, 2024
aea36b8
Rename _min_data_sequence_number to _min_sequence_number in ManifestW…
soumya-ghosh Jul 8, 2024
55b9985
Fix comments and method name
soumya-ghosh Jul 9, 2024
32e0732
Fix variables in upstream code
soumya-ghosh Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename _min_data_sequence_number to _min_sequence_number in ManifestW… 
…riter
  • Loading branch information
@soumya-ghosh
soumya-ghosh committed Jul 10, 2024
commit aea36b8a8c669f69bcd0a151dc87aa5c2f88c8b7
2 changes: 1 addition & 1 deletion pyiceberg/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ class ManifestWriter(ABC):
_existing_rows: int
_deleted_files: int
_deleted_rows: int
_min_data_sequence_number: Optional[int]
_min_sequence_number: Optional[int]
_partitions: List[Record]
_reused_entry_wrapper: ManifestEntry

Expand Down