-
Notifications
You must be signed in to change notification settings - Fork 14.8k
KAFKA-19964: API Versions Response returns minimum metadata version for finalized level when no quorum exists #21122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mannoopj
wants to merge
8
commits into
apache:trunk
Choose a base branch
from
mannoopj:KAFKA-19964
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6d53ead
Add optional FinalizedFeatures
mannoopj 3126d1c
Revert "Add optional FinalizedFeatures"
mannoopj 80de492
Have MetadataVersion be optional rather than FinalizedFeatures
mannoopj 08fcd72
remove FinalizedFeatures.EMPTY
mannoopj f072ffb
nit fixes
mannoopj 92e34e4
reverse removal of isControllerRegistrationSupported check
mannoopj 1175997
add SimpleApiVersionManagerTest
mannoopj ca35b06
change assert in SimpleApiVersionManagerTest
mannoopj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add SimpleApiVersionManagerTest
- Loading branch information
commit 117599724d4e83be4ddc22af51e414fba7a95ce1
There are no files selected for viewing
55 changes: 55 additions & 0 deletions
55
server/src/test/java/org/apache/kafka/server/SimpleApiVersionManagerTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.kafka.server; | ||
|
|
||
| import org.apache.kafka.common.message.ApiMessageType; | ||
| import org.apache.kafka.common.requests.ApiVersionsResponse; | ||
| import org.apache.kafka.server.common.FinalizedFeatures; | ||
| import org.apache.kafka.server.common.MetadataVersion; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertFalse; | ||
|
|
||
| public class SimpleApiVersionManagerTest { | ||
|
|
||
| @Test | ||
| public void testUnknownFeaturesHasNoMetadataVersion() { | ||
| // When no quorum exists, featuresProvider returns UNKNOWN_FINALIZED_FEATURES | ||
| // which has no metadata version and empty finalized features | ||
| SimpleApiVersionManager apiVersionManager = new SimpleApiVersionManager( | ||
| ApiMessageType.ListenerType.CONTROLLER, | ||
| true, | ||
| () -> FinalizedFeatures.UNKNOWN_FINALIZED_FEATURES | ||
| ); | ||
|
|
||
| ApiVersionsResponse response = apiVersionManager.apiVersionResponse(0, false); | ||
|
|
||
| // Verify that metadata.version is not present in finalized features | ||
| assertFalse( | ||
| response.data().finalizedFeatures().stream() | ||
| .anyMatch(f -> f.name().equals(MetadataVersion.FEATURE_NAME)), | ||
| "Finalized features should not contain metadata.version when no quorum exists" | ||
| ); | ||
|
|
||
| // Verify epoch is -1 (unknown) | ||
| assertEquals(-1, response.data().finalizedFeaturesEpoch(), | ||
| "Finalized features epoch should be -1 when no quorum exists"); | ||
| } | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we assert something stronger: that the response's
finalizedFeaturesis empty?