[KYUUBI #3435] Command should not execute when plan only mode is set to PHYSICAL or EXECUTION #3439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxzl25
reviewed
Sep 8, 2022
...k-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/PlanOnlyStatement.scala
Outdated
Show resolved
Hide resolved
Member
|
This change doesn't seem to be compatible with Spark 3.1, can you make it compatible? |
Codecov Report
@@ Coverage Diff @@
## master #3439 +/- ##
=========================================
Coverage 51.92% 51.92%
Complexity 13 13
=========================================
Files 508 522 +14
Lines 29029 29049 +20
Branches 3985 3887 -98
=========================================
+ Hits 15072 15084 +12
- Misses 12532 12590 +58
+ Partials 1425 1375 -50
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lsm1
commented
Sep 13, 2022
| val physical = spark.sessionState.planner.plan(ReturnAnswer(optimized)).next() | ||
| iter = new IterableFetchIterator(Seq(Row(physical.toJSON))) | ||
| case ExecutionMode => | ||
| warn("Plan like Command will real execute") |
Contributor
Author
There was a problem hiding this comment.
ExplainCommand return string, when use json style ,the plan cannot be wrapped as ExplainCommand.Add warning for this case
Member
|
shall we remove this two? they are dangerous and not very useful |
Contributor
Author
|
SPARK-35378 add |
Member
|
ok |
Member
|
this introduces unstable private class from spark, not a good solution to me |
cxzl25
approved these changes
Sep 28, 2022
lsm1
force-pushed
the
features/optimizer_only_plan_mode
branch
from
6c49c3b to
9aabe04
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
close #3435
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request