Skip to content

Conversation

@wForget
Copy link
Member

@wForget wForget commented Aug 1, 2024

🔍 Description

Issue References 🔗

This pull request fixes #6574

Describe Your Solution 🔧

Skip eagerly execute command in physical and execution plan only mode

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Related Unit Tests

added unit test


Checklist 📝

Be nice. Be informative.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (c94f0d7) to head (6f79228).

Files Patch % Lines
...ubi/engine/spark/operation/PlanOnlyStatement.scala 0.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6575   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         677     677           
  Lines       41806   41806           
  Branches     5711    5711           
======================================
  Misses      41806   41806           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wForget wForget self-assigned this Aug 1, 2024
@wForget wForget marked this pull request as ready for review August 1, 2024 15:00
@wForget wForget requested review from pan3793 and ulysses-you August 2, 2024 02:12
@ulysses-you
Copy link
Contributor

I know we have dropped support Spark3.1, but this pr would make it fail to compile with Spark3.1 and previous. I just post this issue and I'm fine if it is acceptable for the community.

@wForget
Copy link
Member Author

wForget commented Aug 2, 2024

I know we have dropped support Spark3.1, but this pr would make it fail to compile with Spark3.1 and previous. I just post this issue and I'm fine if it is acceptable for the community.

Some incompatibilities with spark 3.1 have been introduced since #6273

@pan3793
Copy link
Member

pan3793 commented Aug 2, 2024

branch-1.9 still works for Spark 3.1, if this is only target to master, it is fine to break 3.1

@wForget wForget added this to the v1.10.0 milestone Aug 2, 2024
@pan3793 pan3793 closed this in 93285f1 Aug 5, 2024
@pan3793
Copy link
Member

pan3793 commented Aug 5, 2024

Thanks, merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Skip eagerly execute command in PlanOnly mode of Spark Engine

4 participants