Skip to content

Conversation

@turboFei
Copy link
Member

@turboFei turboFei commented Apr 6, 2021

turboFei Closes #489 1 1 3 Powered by Pull Request Badge

Why are the changes needed?

Bind host to 127.0.0.1 in initialize phase, so that even some suite override the beforeAll method and invoke super.beforeAll after start service.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@turboFei turboFei changed the title [KYUUBI #479][TEST][FOLLOWUP] Set FRONTEND_BIND_HOST to 127.0.0.1 in initialize [KYUUBI #479][TEST][FOLLOWUP] Bind host to 127.0.0.1 in initialize Apr 6, 2021
@turboFei
Copy link
Member Author

turboFei commented Apr 6, 2021

SparkOperationSuite:
*** RUN ABORTED ***
  java.net.BindException: Cannot assign requested address: Service 'sparkDriver' failed after 16 retries (on a random free port)! Consider explicitly setting the appropriate binding address for the service 'sparkDriver' (for example spark.driver.bindAddress for SparkDriver) to the correct binding address.
  at sun.nio.ch.Net.bind0(Native Method)
  at sun.nio.ch.Net.bind(Net.java:461)
  at sun.nio.ch.Net.bind(Net.java:453)
  at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:222)
  at io.netty.channel.socket.nio.NioServerSocketChannel.doBind(NioServerSocketChannel.java:134)
  at io.netty.channel.AbstractChannel$AbstractUnsafe.bind(AbstractChannel.java:550)
  at io.netty.channel.DefaultChannelPipeline$HeadContext.bind(DefaultChannelPipeline.java:1334)
  at io.netty.channel.AbstractChannelHandlerContext.invokeBind(AbstractChannelHandlerContext.java:506)
  at io.netty.channel.AbstractChannelHandlerContext.bind(AbstractChannelHandlerContext.java:491)
  at io.netty.channel.DefaultChannelPipeline.bind(DefaultChannelPipeline.java:973)

with Eventually
with ThreadAudit
with Logging {
// scalastyle:on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relate about this pr, why here forbid scalastyle check ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try to remove it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The forbid is necessary because of the rule:

  <check customId="funsuite" level="error" class="org.scalastyle.scalariform.TokenChecker" enabled="true">
    <parameters><parameter name="regex">^FunSuite[A-Za-z]*$</parameter></parameters>
    <customMessage>Tests must extend org.apache.kyuubi.KyuubiFunSuite instead.</customMessage>
  </check>

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #489 (006e761) into master (2eb4a27) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #489   +/-   ##
=======================================
  Coverage   81.70%   81.70%           
=======================================
  Files         116      116           
  Lines        4247     4247           
  Branches      514      514           
=======================================
  Hits         3470     3470           
  Misses        498      498           
  Partials      279      279           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eb4a27...006e761. Read the comment docs.

@pan3793
Copy link
Member

pan3793 commented Apr 8, 2021

There are some issues on GitHub Action this days, and since travis-CI passed, I will merge it. Thx.

@pan3793 pan3793 closed this in 0a3862a Apr 8, 2021
@pan3793 pan3793 added the Test label Apr 8, 2021
@pan3793 pan3793 added this to the v1.2.0 milestone Apr 8, 2021
@pan3793 pan3793 linked an issue Apr 8, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FrontendServiceSuite- BindException: Cannot assign requested address

4 participants