-
Notifications
You must be signed in to change notification settings - Fork 972
[KYUUBI #479][TEST][FOLLOWUP] Bind host to 127.0.0.1 in initialize #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| with Eventually | ||
| with ThreadAudit | ||
| with Logging { | ||
| // scalastyle:on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not relate about this pr, why here forbid scalastyle check ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me try to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The forbid is necessary because of the rule:
<check customId="funsuite" level="error" class="org.scalastyle.scalariform.TokenChecker" enabled="true">
<parameters><parameter name="regex">^FunSuite[A-Za-z]*$</parameter></parameters>
<customMessage>Tests must extend org.apache.kyuubi.KyuubiFunSuite instead.</customMessage>
</check>
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
=======================================
Coverage 81.70% 81.70%
=======================================
Files 116 116
Lines 4247 4247
Branches 514 514
=======================================
Hits 3470 3470
Misses 498 498
Partials 279 279 Continue to review full report at Codecov.
|
|
There are some issues on GitHub Action this days, and since travis-CI passed, I will merge it. Thx. |
Why are the changes needed?
Bind host to 127.0.0.1 in initialize phase, so that even some suite override the beforeAll method and invoke super.beforeAll after start service.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request