Skip to content

[KYUUBI #479][TEST][FOLLOWUP] Bind host to 127.0.0.1 in initialize #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
turboFei wants to merge 3 commits into from
Closed

[KYUUBI #479][TEST][FOLLOWUP] Bind host to 127.0.0.1 in initialize #489

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
284c1f8
[KYUUBI #479][TEST][FOLLOWUP] Set FRONTEND_BIND_HOST to 127.0.0.1 in …
turboFei Apr 6, 2021
67b4ed5
set spark.driver.bindAddress to 127.0.0.1
turboFei Apr 6, 2021
006e761
remove and try
turboFei Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kyuubi-common/src/test/scala/org/apache/kyuubi/KyuubiFunSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ trait KyuubiFunSuite extends FunSuite
with ThreadAudit
with Logging {
// scalastyle:on
Copy link
Contributor

@ulysses-you ulysses-you Apr 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relate about this pr, why here forbid scalastyle check ？

Copy link
Member

@pan3793 pan3793 Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try to remove it.

Copy link
Member

@pan3793 pan3793 Apr 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The forbid is necessary because of the rule:

  <check customId="funsuite" level="error" class="org.scalastyle.scalariform.TokenChecker" enabled="true">
    <parameters><parameter name="regex">^FunSuite[A-Za-z]*$</parameter></parameters>
    <customMessage>Tests must extend org.apache.kyuubi.KyuubiFunSuite instead.</customMessage>
  </check>

System.setProperty(KyuubiConf.FRONTEND_BIND_HOST.key, "127.0.0.1")
override def beforeAll(): Unit = {
System.setProperty(IS_TESTING.key, "true")
System.setProperty(KyuubiConf.FRONTEND_BIND_HOST.key, "127.0.0.1")
doThreadPostAudit()
super.beforeAll()
}
Expand Down