-
Notifications
You must be signed in to change notification settings - Fork 980
[KYUUBI #6250] Drop support for Spark 3.1 #6273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
thanks for making this PR, I noticed there are some places missed, you can search codebase in |
.../kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/sql/kyuubi/SparkDatasetHelper.scala
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6273 +/- ##
============================================
+ Coverage 58.37% 58.46% +0.09%
Complexity 24 24
============================================
Files 651 651
Lines 39560 39550 -10
Branches 5447 5449 +2
============================================
+ Hits 23092 23123 +31
+ Misses 13982 13948 -34
+ Partials 2486 2479 -7 ☔ View full report in Codecov by Sentry. |
...k-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/FetchOrcStatement.scala
Outdated
Show resolved
Hide resolved
.../kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/sql/kyuubi/SparkDatasetHelper.scala
Outdated
Show resolved
Hide resolved
…ark/sql/kyuubi/SparkDatasetHelper.scala
|
LGTM if CI pass |
cfmcgrady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks, merged to master |
🔍 Description
Issue References 🔗
This pull request fixes #6250
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes 🔖
Test Plan 🧪
Pass CI
Checklist 📝
Be nice. Be informative.