Skip to content

Conversation

@liuxiaocs7
Copy link
Contributor

@liuxiaocs7 liuxiaocs7 commented Apr 7, 2024

🔍 Description

Issue References 🔗

This pull request fixes #6250

Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Pass CI


Checklist 📝

Be nice. Be informative.

@github-actions github-actions bot added kind:documentation Documentation is a feature! kind:infra license, community building, project builds, asf infra related, etc. module:spark labels Apr 7, 2024
@liuxiaocs7 liuxiaocs7 changed the title Drop support for Spark 3.1 [KYUUBI #6250] Drop support for Spark 3.1 Apr 7, 2024
@pan3793
Copy link
Member

pan3793 commented Apr 7, 2024

thanks for making this PR, I noticed there are some places missed, you can search codebase in kyuubi-spark-sql-engine module with keywords "3.2"

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 58.46%. Comparing base (4fcc5c7) to head (c6ba1e8).
Report is 5 commits behind head on master.

Files Patch % Lines
...uubi/engine/spark/operation/ExecuteStatement.scala 0.00% 2 Missing ⚠️
...ubi/engine/spark/operation/FetchOrcStatement.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6273      +/-   ##
============================================
+ Coverage     58.37%   58.46%   +0.09%     
  Complexity       24       24              
============================================
  Files           651      651              
  Lines         39560    39550      -10     
  Branches       5447     5449       +2     
============================================
+ Hits          23092    23123      +31     
+ Misses        13982    13948      -34     
+ Partials       2486     2479       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pan3793
Copy link
Member

pan3793 commented Apr 8, 2024

LGTM if CI pass

@pan3793 pan3793 added this to the v1.10.0 milestone Apr 8, 2024
Copy link
Contributor

@cfmcgrady cfmcgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pan3793 pan3793 closed this in 42c619a Apr 8, 2024
@pan3793
Copy link
Member

pan3793 commented Apr 8, 2024

Thanks, merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:documentation Documentation is a feature! kind:infra license, community building, project builds, asf infra related, etc. module:spark

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TASK][EASY] Drop support for Spark 3.1

4 participants