Skip to content

Bug: GH-1703 Locally cached artifacts defy RRF #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cstamas merged 4 commits into from
Dec 11, 2025
Merged

Bug: GH-1703 Locally cached artifacts defy RRF #1707

cstamas merged 4 commits into from
Dec 11, 2025

Conversation

@cstamas
Copy link
Member

@cstamas cstamas commented Dec 10, 2025 •
edited
Loading

Within ArtifactResolver there was a subtle bug, caused by unintentional lazy evaluation of logical OR. In case filter is present, it is ONLY and only LRM availability that drives the logic.

@cstamas
Bug: apacheGH-1703 Two
6fea86d 
Within ArtifactResolver there was a subtle bug, caused by
unintentional lazy evaluation of logical OR. In case filter is
present, it is ONLY and only lrm availability that drives
the logic.
@cstamas cstamas self-assigned this Dec 10, 2025
@cstamas cstamas added the bug Something isn't working label Dec 10, 2025
@cstamas cstamas added this to the 2.0.14 milestone Dec 10, 2025
@cstamas cstamas requested a review from gnodet December 10, 2025 21:02
@cstamas cstamas mentioned this pull request Dec 10, 2025
Closed
@cstamas cstamas changed the title Bug: GH-1703 Two Bug: GH-1703 Locally cached artifacts defy RRF Dec 10, 2025
@cstamas
Copy link
Member Author

cstamas commented Dec 10, 2025

This applies to Resolver 1.9 as well:

maven-resolver/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java

Line 365 in 7d7dc54

boolean found = (filter != null && local.isAvailable()) || isLocallyInstalled(local, versionResult);

@cstamas cstamas marked this pull request as ready for review December 10, 2025 21:31
@cstamas cstamas mentioned this pull request Dec 10, 2025
Merged
@cstamas cstamas linked an issue Dec 10, 2025 that may be closed by this pull request
GroupId filtering doesn't allow group children as documented #1703
Closed
@cstamas cstamas merged commit f815732 into apache:master Dec 11, 2025
27 of 28 checks passed
@cstamas cstamas deleted the gh-1703-two branch December 11, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnodet gnodet gnodet approved these changes

@slawekjaranowski slawekjaranowski Awaiting requested review from slawekjaranowski

Assignees

@cstamas cstamas

Labels

bug Something isn't working

Projects

None yet

Milestone

2.0.14

Development

Successfully merging this pull request may close these issues.

GroupId filtering doesn't allow group children as documented

2 participants

@cstamas @gnodet