Skip to content

Bug: GH-1703 Locally cached artifacts defy RRF #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cstamas merged 4 commits into from
Dec 11, 2025
Merged

Bug: GH-1703 Locally cached artifacts defy RRF #1707

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fea86d
Bug: GH-1703 Two
cstamas Dec 10, 2025
b8a4e4c
Add UT
cstamas Dec 10, 2025
381f644
Javadoc and explain
cstamas Dec 10, 2025
db52caf
Typo
cstamas Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Bug: GH-1703 Two 
Within ArtifactResolver there was a subtle bug, caused by
unintentional lazy evaluation of logical OR. In case filter is
present, it is ONLY and only lrm availability that drives
the logic.
  • Loading branch information
@cstamas
cstamas committed Dec 10, 2025
commit 6fea86d103c120ad5af51a0954e34ba17b7c2f2d
7 changes: 4 additions & 3 deletions ...resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,9 +312,10 @@ private List<ArtifactResult> resolve(
new LocalArtifactRequest(
artifact, filteredRemoteRepositories, request.getRequestContext()));
result.setLocalArtifactResult(local);
boolean found = (filter != null && local.isAvailable()) || isLocallyInstalled(local, versionResult);
// with filtering it is availability that drives logic
// without filtering it is simply presence of file that drives the logic
boolean found = (filter != null && local.isAvailable())
|| (filter == null && isLocallyInstalled(local, versionResult));
// with filtering: availability drives the logic
// without filtering: simply presence of file drives the logic
// "interop" logic with simple LRM leads to RRF breakage: hence is ignored when filtering in effect
if (found) {
if (local.getRepository() != null) {
Expand Down